False-positive void-return in dtslint after adding awaited #37551

Activity

1. Maxim-Mazurok commented on Mar 24, 2020

   

   Maxim Mazurok (Maxim-Mazurok)

   on Mar 24, 2020

   Last edited by Maxim-Mazurok

   Author

   More actions

   Sorry, it seems like a dstlint issue actually.
   It's using bundled TS (node_modules/dtslint/nodemodules/typescript) for rules, but project's TS (node_modules/typescript) for parsing sources before running rules on them.
   So, node kinds reported by older TS version are not matching with the new ones (for example, SyntaxKind.VoidKeyword). That's what was causing problems, as node kinds were updated in this PR.
   Probably it would be great to have backward-compatibility in this matter, so I'm not closing the issue.
2. Ryan Cavanaugh (RyanCavanaugh)

   added

   ExternalRelates to another program, environment, or user action which we cannot control.Relates to another program, environment, or user action which we cannot control.

   on Mar 24, 2020
3. RyanCavanaugh commented on Mar 24, 2020

   

   Ryan Cavanaugh (RyanCavanaugh)

   on Mar 24, 2020

   Member

   More actions

   We don't support this kind of back compat
4. Maxim-Mazurok commented on Mar 25, 2020

   

   Maxim Mazurok (Maxim-Mazurok)

   on Mar 25, 2020

   Author

   More actions

   Ryan Cavanaugh (@RyanCavanaugh) I hear you. But what if we could support it?
   From what I understand, it would require changing

   TypeScript/src/compiler/types.ts

   Lines 124 to 127 in a1c8608

   	export const enum SyntaxKind {
   	Unknown,
   	EndOfFileToken,
   	SingleLineCommentTrivia,

   to

   export const enum SyntaxKind { 
        Unknown = "Unknown", 
        EndOfFileToken = "EndOfFileToken", 
        SingleLineCommentTrivia = "SingleLineCommentTrivia",

   Kind of like it was did in

   TypeScript/src/compiler/types.ts

   Lines 4207 to 4210 in a1c8608

   	export const enum InternalSymbolName {
   	Call = "__call", // Call signatures
   	Constructor = "__constructor", // Constructor implementations
   	New = "__new", // Constructor signatures

   Another approach is to do this like for different flags

   TypeScript/src/compiler/types.ts

   Lines 4163 to 4166 in a1c8608

   	export const enum CheckFlags {
   	Instantiated = 1 << 0, // Instantiated symbol
   	SyntheticProperty = 1 << 1, // Property in union or intersection type
   	SyntheticMethod = 1 << 2, // Method in union or intersection type

   so it will look like

   export const enum SyntaxKind { 
        Unknown                 = 1 << 0, 
        EndOfFileToken          = 2 << 0, 
        SingleLineCommentTrivia = 3 << 0,

   or even simpler:

   export const enum SyntaxKind { 
        Unknown                 = 0, 
        EndOfFileToken          = 1, 
        SingleLineCommentTrivia = 2,

   Any of these approaches will preserve enum values and make TS even more back compat :) What do you think?
5. Ron Buckton (rbuckton)

   closed this as completedin #37610on Mar 26, 2020
6. Maxim-Mazurok commented on Mar 30, 2020

   

   Maxim Mazurok (Maxim-Mazurok)

   on Mar 30, 2020

   Author

   More actions

   Ron Buckton (@rbuckton) what do you think about #37551 (comment) ?
   I think if we use this approach - we can eliminate potential issues when updating SyntaxKind in the future.