Repository navigation
Make trailing commas on binding/rest not an error in .d.ts files #23070
Description
Activity
Can we emit a warning instead? Silent is not a good solution either.
Declaration files will never be executed and are just metadata (for the compiler itself) - I think we can silently be more permissive in them.
But it would be nice to be able to detect them somehow so that typings authors can fix them easily.
Another way is to rely on ts-lint auto-fix to remove all trailing commas. :)
Those tools can still find and remove trailing rest/bind commas; we just don't need to report an error in a
.d.ts- it's unhelpful and unneeded.#23139 results in breaking code builds with
error TS1013: A rest parameter or binding pattern may not have a trailing comma.In my case, it happens in non
*.d.tscode.I agree with Homa Wong (@unional), it should be a warning, unless bumping a major version is okay for such a small change.
Reacted by Igor Soloydenko- locked and limited conversation to collaborators
on Jul 31, 2018
#22262 is pretty breaky, and the change is to be more spec compliant. To reduce how breaky the change is, we shouldn't report the error if it happens in a
.d.tsfile, as there will be no associated emit - this way older.d.tsfiles won't need to be updated just to remove trailing commas that we can actually handle just fine.