This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Optimization: Remove redundant list call in check_file in Build/check_indents.py #602
Description
In the check_file function of Build/check_indents.py, it is performing a redundant list call, on f.readlines() which itself returns a list, in line 28:
def check_file(filename : str) -> bool:
...
with open(filename, 'r') as f:
contents = list(f.readlines())
...This can have impact on performance, if the file is really large. This does not have any benefit over the plain f.readlines() either.
I propose the following change:
- contents = list(f.readlines())
+ contents = f.readlines()
Activity
sayandipdutta commentedon Feb 4, 2022
Would be happy to add a PR, if the above proposal sounds reasonable.
cgranade commentedon Feb 24, 2022
Thanks for raising this, and for your patience! Would be happy if you'd still be interested in opening a PR!
sayandipdutta commentedon Feb 25, 2022
Sure, I will add one today.
Optimize by removing redundant `list` call (microsoft#602)