Repository navigation
Implement equality (IEquatable<T> and override object.Equals/GetHashCode) for object models #2989
Description
Activity
Hi Youssef Fahmy (@Youssef1313)
Thank you for using the SDK and for reaching out.We do have a super old issue in the same realm #414
Overall, what's the best to implement:
- IEquatable
- IEqualityComparer
- IComparer
- all of the above?
I think
IEquatable<T>,object.EqualsandGetHashCodeare the most important.I don't feel
IComparermakes a lot sense, because it's about making the decision of less than, greater than, or equal. I don't think less than and greater than are meaningful for OpenAPI object model.IEqualityComparer<T>might not be super important unless there can be different implementations/meanings of "equality" and there will be multiple exposed implementations of it.All of them do comparison in the end for slightly different scenarios.
If we implemented IEquitable, we could think later on about pointing IEqualityComparer to it essentially and would be left with IComparer to really implement (assuming we get customer request for any of them)
I want to be able to compare two different OpenApiSchema instances for equality. I think it would make sense to implement equality on all object model types so that they implement
IEquatable<T>and overrideobject.EqualsandGetHashCodemethods.