Repository navigation
[US] Remove XML DOM Management usage from IRS Forms (IRIS) - #12646
Draft
Darrick (darjoo) wants to merge 1 commit into
Draft
Darrick (darjoo) wants to merge 1 commit into
Darrick (darjoo) wants to merge 1 commit into
Conversation
Replace codeunit 6224 'XML DOM Management' calls in Helper IRIS with System Application codeunit 'XML Utilities' (GetUtf8BomSymbols, TryGetXmlAsText), which have identical implementations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Part of retiring Base App codeunit 6224 "XML DOM Management". The US IRS Forms app used it in
Helper IRIS(codeunit 10035) for two calls only; both are replaced by the System Application codeunit 3016 "XML Utilities" (System.Xml) introduced in #12629:XMLDOMManagement.GetUTF8BOMSymbols()XMLUtilities.GetUtf8BomSymbols()XMLDOMManagement.TryGetXMLAsText(InStream, Text)XMLUtilities.TryGetXmlAsText(InStream, Text)TryGetXmlAsTextkeeps the exact same implementation (DotNetXmlDocument,PreserveWhitespace(false),Load,OuterXml, empty-stream error) and is still a[TryFunction]whose return value is ignored, soWriteTempBlobToText— which produces the IRIS transmission / status request payload sent to the IRS and the parsed responses/acknowledgements — returns identical text.GetUtf8BomSymbolsreturns U+FEFF in both cases. No DotNet is added to the app, no public signatures change, and no other file in the app, test library or test project references XML DOM Management.Depends on #12629 (stacked on
darjoo-xml-dom-s0-replacement-api).Linked work
Fixes AB#649587
How I validated this
What I tested and the outcome
CI build jobs don't run on PRs based on a non-main branch, so compiled locally without a container (all BC local container pool slots were leased):
alc.exe /project:"src\System Application\App" /packagecachepath:<platform System.app> /assemblyprobingpaths:<ServiceTier\Service>→ succeeded.git archive 1165b6e0) with CodeCop + UICop against the US 30.0.55871.0 artifact (Application, Base Application, Business Foundation, Exclude_Business_Events) plus the branch System Application:alc.exe /project:src\Apps\US\IRSForms\app /packagecachepath:<pcus> /assemblyprobingpaths:<Service> /analyzer:CodeCop /analyzer:UICop→ both exit 0; diagnostics identical (32 vs 32, no new warnings/errors).IRS 1099 IRIS Tests(148022).Risk & compatibility
None expected. Output of the IRIS XML payload is unchanged. Requires #12629 to be merged first.