Repository navigation
Conversation
Currently, when publishing core packages, we use NPM for "production" releases but GitHub Package Registry for "preview" builds. This works to keep the list of production versions free of clutter and mitigate the risk of publishing preview builds as production releases accidentally, but it also introduces a major pain point. Usually in order to access a package with a preview build, the developer must instruct Yarn to use GitHub Package Registry instead of NPM along with an authentication token, and then update the version of the package in the manifest to use the preview version. If, however, the package introduces a new transitive dependency that is not available in preview form, the developer must undo the changes to the Yarn configuration or even temporarily add the dependency explicitly to the project in order to fully install it. In some cases, these steps don't work at all. To remove this pain point, this commit changes how preview builds are published so that instead of using a separate registry, we use a separate NPM scope. This preserves the separation between preview builds and non-preview builds, and it means that the developer can mix non-preview and preview versions in the manifest without needing to reconfigure Yarn.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Owner
Author
|
@metamaskbot publish-preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST