Repository navigation
Ignore not-found errors in Sentry - #3602
Open
thecristen wants to merge 1 commit into
Open
thecristen wants to merge 1 commit into
thecristen wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
I am unable to get the new test to run using the steps provided: The other changes look fine to me. |
joshlarson
requested changes
Oct 16, 2026
joshlarson
left a comment
Contributor
There was a problem hiding this comment.
Echoing Luc's comment, the new test causes the build to fail.
Other Sentry exclusions aren't tested, and I'm not 100% convinced that we need this one to be either.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DotcomWeb.NotFoundErrorfrom Sentry reporting because the router renders it as a normal 404 response.References
Validation
mix test test/dotcom/sentry_test.exs— not run: dependencies are unavailable in this checkout.mix format --check-formatted lib/sentry.ex test/dotcom/sentry_test.exs— not run: Phoenix dependency is unavailable in this checkout.