You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 15, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 15, 2026. It is now read-only.
ClusterController uses :wait for starting, but not stopping (or restarting) #310
This was fine, because the --timeout wasn't passed into the server. It looks like that in 1.6.4, the servers started taking timeout configurations, so as of that version our command-line script wasn't just timing out the restart, it was setting a timeout config for the servers it restarted as well.
But this doesn't do what we want either; the --wait is filtered out of the start & stop jobs created by Thin::Controllers::Cluster using Thin::Command. I had started to work on a PR to pass --wait through from the cluster controller, but since it appears that it was omitted on purpose, I figured I'd file this issue to see if there was a better way, or if --wait was omitted because it was a problem.
Activity
emschwar commentedon Mar 22, 2017
Is there something I can do to help move this along? Any changes you'd like to the accompanying PR?