Repository navigation
[CI] Test on current Ruby versions - #10
Merged
Merged
Conversation
fluent/test loads test-unit, whose at_exit autorunner parses ARGV again, does not know --format and exits 1 after all examples passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI matrix stopped at Ruby 3.0.0, so no job ever installed the fluentd that current fluent-package releases ship (fluentd 1.19 requires Ruby 3.2+). This brings the build workflow in line with logtail-ruby:
3join the matrix; 2.4–3.0 stay, now as minor versions so setup-ruby picks the newest patch. Bundler resolves fluentd per Ruby, so the old Rubies keep covering fluentd 1.16 and 1.18 and the new ones cover 1.19.fail-fast: false, so one red Ruby does not cancel the others.main, pull requests, weekly (Monday 05:20 UTC) and on demand, instead of on every push to every branch.The plugin needed no change for Ruby 4.0. The first commit is red on every job for a self-inflicted reason: it also copied
--format documentationfrom logtail-ruby, andfluent/testloads test-unit, whoseat_exitautorunner parses ARGV again, rejects the rspec flag and exits 1 after all examples passed. The second commit drops the flag and the whole matrix is green.🤖 Generated with Claude Code