Repository navigation
Pass the first-interaction wrapper its own input names - #406
Conversation
The linuxserver first-interaction composite action takes issue_message, pr_message and repo_token, but the greetings template still passes the issue-message, pr-message and repo-token names of actions/first-interaction@v1. GitHub drops them, the wrapper hands empty messages to actions/first-interaction@v3.1.0, and that fails on every opened issue and pull request with "Input required and not supplied: issue_message". closes linuxserver#405 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RmwHZxdRuWgp9chBZTZTMn
There was a problem hiding this comment.
LGTM! Good Catch!
I see what happened. The upstream action switched from dashes to underscores (certainly a breaking change) and did NOT document that breaking change in a meaningful way (no mention in the release notes https://github.com/actions/first-interaction/releases/tag/v2.0.0 or readme https://github.com/actions/first-interaction/blob/main/README.md about the change, the PR actions/first-interaction#311 that did it doesn't mention it, but the code change is there).
When I wrote the composite action in our workflows repository in linuxserver/github-workflows#66 I based it on the action file in the upstream repo at the time (which had already silently switched from dashes to underscores) and did not make the appropriate changes here to our template (which you have done). Prior to switching to our composite actions in our workflows repo, we were using an old version of first-interaction which still used the dashes.
Description:
greetings.yml.j2now passesissue_message,pr_messageandrepo_token, the input names declared bylinuxserver/github-workflows/.github/actions/first-interaction@v1, instead of theissue-message,pr-messageandrepo-tokennames ofactions/first-interaction@v1.Benefits of this PR and context:
closes #405
The
greetingjob stops failing on every opened issue and pull request of the repositories generated from this template, and first-time contributors get their message again.How Has This Been Tested?
project_deprecation_statusfalse and true: valid YAML whosewithkeys match the wrapper's inputs, and actionlint 1.7.12 reports nothing.actions/first-interactionv3.1.0dist/index.jslocally on anopenedissue event. With empty messages, which is what the wrapper passes today, it fails withInput required and not supplied: issue_message. With the messages set, it gets past the inputs to the GitHub API calls.Source / References: