Skip to content

Pass the first-interaction wrapper its own input names - #406

Merged
nemchik merged 1 commit into
linuxserver:monthlyfrom
tigerblue77:claude/fix-greetings-inputs
Sep 28, 2026
Merged

nemchik merged 1 commit into
linuxserver:monthlyfrom
tigerblue77:claude/fix-greetings-inputs

Conversation

@tigerblue77

Copy link
Copy Markdown

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

greetings.yml.j2 now passes issue_message, pr_message and repo_token, the input names declared by linuxserver/github-workflows/.github/actions/first-interaction@v1, instead of the issue-message, pr-message and repo-token names of actions/first-interaction@v1.

Benefits of this PR and context:

closes #405

The greeting job stops failing on every opened issue and pull request of the repositories generated from this template, and first-time contributors get their message again.

How Has This Been Tested?

  • Rendered the template with project_deprecation_status false and true: valid YAML whose with keys match the wrapper's inputs, and actionlint 1.7.12 reports nothing.
  • Ran actions/first-interaction v3.1.0 dist/index.js locally on an opened issue event. With empty messages, which is what the wrapper passes today, it fails with Input required and not supplied: issue_message. With the messages set, it gets past the inputs to the GitHub API calls.

Source / References:

The linuxserver first-interaction composite action takes issue_message,
pr_message and repo_token, but the greetings template still passes the
issue-message, pr-message and repo-token names of
actions/first-interaction@v1. GitHub drops them, the wrapper hands
empty messages to actions/first-interaction@v3.1.0, and that fails on
every opened issue and pull request with "Input required and not
supplied: issue_message".

closes linuxserver#405

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RmwHZxdRuWgp9chBZTZTMn
@thelamer
thelamer changed the base branch from master to monthly September 28, 2026 14:33
@thelamer
thelamer requested a review from nemchik September 28, 2026 14:41

@nemchik nemchik left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good Catch!

I see what happened. The upstream action switched from dashes to underscores (certainly a breaking change) and did NOT document that breaking change in a meaningful way (no mention in the release notes https://github.com/actions/first-interaction/releases/tag/v2.0.0 or readme https://github.com/actions/first-interaction/blob/main/README.md about the change, the PR actions/first-interaction#311 that did it doesn't mention it, but the code change is there).

When I wrote the composite action in our workflows repository in linuxserver/github-workflows#66 I based it on the action file in the upstream repo at the time (which had already silently switched from dashes to underscores) and did not make the appropriate changes here to our template (which you have done). Prior to switching to our composite actions in our workflows repo, we were using an old version of first-interaction which still used the dashes.

@github-project-automation github-project-automation Bot moved this from PRs Ready For Team Review to PRs Approved in Issue & PR Tracker Sep 28, 2026
@nemchik
nemchik merged commit a6045f5 into linuxserver:monthly Sep 28, 2026
3 of 4 checks passed
@thelamer thelamer mentioned this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[BUG] Greetings workflow fails on every opened issue and PR: first-interaction inputs use the old names

4 participants