Skip to content

Add 0.5.1 zip to release #441

Description

@pietbrauer

In the most recent carthage release it is possible to attach zips. I tried to build it for 0.6.0 but it is not building because of a libssh2 error.

However I was able to build 0.5.1 and tried to attach it to this ticket, but it is 12,3 MB and Github only allows 10 MB. It would be so cool if I could attach it to the release 🐈

Many Thanks!

Activity

  1. jspahrsummers commented on Feb 16, 2015

    @jspahrsummers
    Contributor

    I've just invited you to be a collaborator. 😊

  2. pietbrauer commented on Feb 16, 2015

    @pietbrauer
    MemberAuthor

    I uploaded the binary and since removed it again because the header search path is not working.

    So everyone including this project via carthage will get the git2/filter.h file not found errors. Because obviously "$(SRCROOT)/Carthage/Checkouts/objective-git/External/libgit2/include/" does no longer exist.

    Any idea?

  3. jspahrsummers commented on Feb 16, 2015

    @jspahrsummers
    Contributor

    Bleh, this is the problem that the module map is intended to solve, but that only came in 0.6.

  4. pietbrauer commented on Feb 17, 2015

    @pietbrauer
    MemberAuthor

    Even with the module map it is not solved (tried with 0.6) and the mac build needs to set HEADER_SEARCH_PATHS too so it can't be an iOS configuration error. Any ideas?

  5. jspahrsummers commented on Feb 17, 2015

    @jspahrsummers
    Contributor

    Sorry, I don't have a whole lot of free time to investigate this, especially because ObjectiveGit is successfully building in our subproject setup. 😕

  6. pietbrauer commented on Feb 17, 2015

    @pietbrauer
    MemberAuthor

    Sure, maybe @phatblat has an idea. He already had a fix every time I opened an issue 😃

  7. jspahrsummers commented on Feb 18, 2015

    @jspahrsummers
    Contributor

    Now that #442 is fixed, I was able to build and upload a binary for 0.6.1. Does that one work?

  8. pietbrauer commented on Feb 18, 2015

    @pietbrauer
    MemberAuthor

    Worked but had to add $(SRCROOT)/Carthage/Build/iOS/ObjectiveGit.framework/Headers/ to HEADER_SEARCH_PATHS

  9. jspahrsummers commented on Feb 18, 2015

    @jspahrsummers
    Contributor

    I wonder if we could fix that by using angle-bracket imports in the module map? Anyways, glad to hear it's working now.

  10. pietbrauer commented on Feb 23, 2015

    @pietbrauer
    MemberAuthor

    You mean like this? That doesn't work.

  11. jspahrsummers commented on Feb 23, 2015

    @jspahrsummers
    Contributor

    Ah, alright. 😞

    Thanks for trying!

  12. zetachang commented on Mar 15, 2015

    @zetachang

    Add HEADER_SEARCH_PATHS do the trick. thanks @pietbrauer !

  13. added a commit that references this issue on Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions