Repository navigation
Better support for optimization in "flattened" Trotter - #116
Merged
Merged
Conversation
… step The coefficient was multiplied by num_steps and num_steps was then set to 1, which also grows dt = time / num_steps by num_steps, so the angle came out num_steps^2 times too large instead of num_steps times.
…r bloq Qualtran gets a sub-bloq's tensors through add_my_tensors, not tensor_contract, so the structured/incremental contraction was skipped (and the bloq decomposed gate by gate) under Power, as_composite_bloq, and user-built circuits. Override add_my_tensors to add the optimized matrix as one dense tensor. The "qualtran" method now contracts decompose_bloq() directly so it remains the gate-by-gate reference rather than routing back through the override. Addresses #108.
…action Qualtran's Adjoint decomposes the subbloq for tensor simulation, bypassing any Trotterization-level override. Return a Trotterization with reversed coefficients, negated time, and (for an odd number of coefficients) reversed term order, which applies the expanded sequence in reverse. Addresses #108.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108