Repository navigation
Conversation
The OKLch track moved from `web/new/` to `web/`, so the docs site, the dev apps and the e2e app
follow it. Component tokens are opt-in in v4, which means skeleton takes its values from
`component-tokens*.css` instead of the removed `web/deprecated/` tree.
`_palette.scss` is gone — it only held the legacy HSL palette, and nothing here read the
`$palette` map.
`TooltipSizeArrowSize` went with the rest of the deprecated component tokens. It aliased
`{size.m}`, which is exactly what its own deprecation notice told consumers to use, so `SizeM`
replaces it — the same 12px, leaving ARROW_BOTTOM_MARGIN_AND_HALF_HEIGHT unchanged.
NOTE: depends on @koobiq/design-tokens v4, which is not published yet, so `yarn.lock` still
resolves ^3.20.0 and an immutable install will not reconcile the two until it is.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…3002) @koobiq/design-tokens v4 dropped the `component-tokens*.css` aggregates and moved each component's tokens under `web/css/components/`. The docs site now forwards the three files it actually renders — code-block, scrollbars, skeleton — instead of the removed aggregate, and naming them individually is the point: it is visible where those base values come from. code-block and scrollbar carried their own copies of tokens the package ships, so the values existed in two places and could drift. The copies are gone. The popover and tooltip dev apps follow the `--kbq-error-default` → `--kbq-background-error` rename. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…#DS-3002) `--kbq-background-overlay-theme` is gone in @koobiq/design-tokens v4, replaced by an opaque base plus `--kbq-opacity-overlay`. The documented way to compose the two is an `opacity` declaration, which this element cannot use: it already animates its own appearance with `opacity: 0 -> 1`, and opacity would fade the dashed border and the empty state along with the background. Mix the alpha into the colour instead, matching the idiom already used by list-tokens.scss and _loader-overlay-theme.scss. `in srgb` rather than `in oklch` for consistency with those two; both were measured to give identical output here, since the base colour is inside the sRGB gamut and mixing with `transparent` only applies alpha. The tint is paler than v3: over white, #9cc2fe -> #c4dfff, and in the dark theme #1442a1 -> #182b66. That follows from the token swap itself, not from the mixing, and is the same shift every consumer of the old token gets. Worth a designer's eyes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wait for @koobiq/design-tokens@4.0.0 release