Skip to content

fix(histoire): ignore deps under hidden roots - #848

Closed
costleya wants to merge 1 commit into
histoire-dev:mainfrom
costleya:fix-847
Closed

costleya wants to merge 1 commit into
histoire-dev:mainfrom
costleya:fix-847

Conversation

@costleya

Copy link
Copy Markdown

Description

Normalize Markdown watcher paths before applying ignore globs so hidden parent directories do not cause dependency traversal.

Fix #847

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Normalize Markdown watcher paths before applying ignore globs so hidden parent directories do not cause dependency traversal.

Fix histoire-dev#847
@codesandbox

codesandbox Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@netlify

netlify Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit ae1689b
🔍 Latest deploy log https://app.netlify.com/projects/histoire-examples-svelte3/deploys/6a67921539c0b700085fa2cf
😎 Deploy Preview https://deploy-preview-848--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit ae1689b
🔍 Latest deploy log https://app.netlify.com/projects/histoire-examples-vue3/deploys/6a679215df14ae0008b1c0da
😎 Deploy Preview https://deploy-preview-848--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit ae1689b
🔍 Latest deploy log https://app.netlify.com/projects/histoire-controls/deploys/6a679215aaed3c0009ced70c
😎 Deploy Preview https://deploy-preview-848--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit ae1689b
🔍 Latest deploy log https://app.netlify.com/projects/histoire-site/deploys/6a6792152c8a7f00091c735a
😎 Deploy Preview https://deploy-preview-848--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@costleya

Copy link
Copy Markdown
Author

Closing as superseded by f89dce8 (f89dce84), which introduced shared ignore handling that excludes dependencies beneath hidden project roots and addresses the original over-watching problem in #847.

@costleya costleya closed this Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden directories cause over-watching (node_modules watched) in dev

1 participant