Skip to content

FE-1757: Move HASH embed chrome onto the plugin API and remove slots - #9913

Draft
kube wants to merge 2 commits into
claude/plugin-v1-welcome-guidefrom
claude/plugin-v1-hash-embed-chrome
Draft

kube wants to merge 2 commits into
claude/plugin-v1-welcome-guidefrom
claude/plugin-v1-hash-embed-chrome

Conversation

@kube

@kube kube commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Before this PR, HASH's process embed passed its breadcrumbs, title style, version picker and Save button to the editor through the slots prop, the last host to use it.

This PR moves that chrome into a HASH plugin with two top-bar items and removes slots from @hashintel/petrinaut: its prop, its type, its exports and its rendering in the top bar and the Labs settings.

Links

Changes

Library

  • slots prop and PetrinautSlots type removed

    Top-bar items and Labs rows come from plugins.

HASH

  • embedChromePlugin places the breadcrumbs at the start of the top bar and the version picker and Save at its end

    The page provides its state to both items through EmbedChromeContext.

Known issues

  • The chrome plugin can be switched off under Plugins, which hides Save for the session

Test coverage

  • user-settings.test.tsx:

    Labs settings without host content.

  • @apps/hash-frontend type check and lint.

How to test

  • Open HASH preview on Vercel
  • Processes > any process

    Expect breadcrumbs with the editable title at the start of the top bar

  • Edit the net

    Expect Save enabled at the end of the top bar

@kube kube self-assigned this Oct 5, 2026
@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hash Ready Ready Preview Oct 9, 2026 2:54am UTC
petrinaut Ready Ready Preview Oct 9, 2026 2:54am UTC
petrinaut-docs Ready Ready Preview Oct 9, 2026 2:54am UTC
1 Skipped Deployment
Project Deployment Actions Updated
hashdotdesign-tokens Ignored Ignored Preview Oct 9, 2026 2:54am UTC

Request Review

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps labels Oct 5, 2026
@CLAassistant

CLAassistant commented Oct 5, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@kube
kube added this pull request to stack #9915 October 5, 2026 01:29
@kube
kube force-pushed the claude/plugin-v1-hash-embed-chrome branch from 8f102fe to 00b60b0 Compare October 5, 2026 12:28
@kube
kube removed this pull request from stack #9915 October 7, 2026 17:11
@kube
kube changed the base branch from claude/plugin-v1-example-title to claude/plugin-v1-welcome-guide October 7, 2026 17:12
@kube
kube force-pushed the claude/plugin-v1-hash-embed-chrome branch from 00b60b0 to 5ebadbe Compare October 7, 2026 17:12
@kube
kube added this pull request to stack #9965 October 7, 2026 17:13
@kube
kube removed this pull request from stack #9965 October 7, 2026 17:13
@kube kube changed the title Add the HASH embed chrome plugin and remove the slots prop Add the HASH embed chrome plugin and remove the top-bar slots keys Oct 7, 2026
@kube
kube force-pushed the claude/plugin-v1-hash-embed-chrome branch from 2ee3be9 to c2108b6 Compare October 8, 2026 10:14
@kube
kube force-pushed the claude/plugin-v1-hash-embed-chrome branch from c2108b6 to b8d7552 Compare October 8, 2026 16:05
@kube
kube force-pushed the claude/plugin-v1-hash-embed-chrome branch from b8d7552 to 3eb1a3d Compare October 8, 2026 16:57
@kube
kube force-pushed the claude/plugin-v1-hash-embed-chrome branch from 3eb1a3d to c6d099f Compare October 8, 2026 22:00
@kube
kube added this pull request to stack #9937 October 8, 2026 22:01
@kube kube changed the title Add the HASH embed chrome plugin and remove the top-bar slots keys FE-1757: Move HASH embed chrome onto the plugin API and remove slots Oct 9, 2026

This branch was successfully deployed

3 active deployments
Preview – hash — 3023386a Deployed Oct 9, 2026 by vercel[bot]
Preview – petrinaut-docs — 3023386a Deployed Oct 9, 2026 by vercel[bot]
Preview – petrinaut — 3023386a Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants