Repository navigation
Bump SonarAnalyzer.CSharp from 10.18.0.131500 to 10.35.0.4138 - #72
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
--- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-version: 10.35.0.4138 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated SonarAnalyzer.CSharp from 10.18.0.131500 to 10.35.0.4138.
Release notes
Sourced from SonarAnalyzer.CSharp's releases.
10.35.0.4138
Release notes - .NET Analyzers - 10.35
Feature
NET-1313 Improve S3267: Suggest other LINQ methods instead of always Where
NET-4549 Update RSPEC before 10.35 release
False Positive
NET-87 Fix S6667 FP: Add an exception when rethrowing the exception
NET-1559 Fix S6966 FP: FluentValidation ValidateAndThrow should not be proposed
NET-3964 Fix S125 FP: Do not raise on comments that resemble code but are not
NET-4294 Fix S107 FP: Should not raise on constructors of dependency-injection managed types
NET-4310 Fix S8747 FP: Do not raise when data is backfilled via UpdateData
NET-4315 Fix S3453 FP: Should not raise on classes with static members and non-static nested types
NET-4415 Fix S8969 FP: redundant null-forgiving operator raised on ref-loop variables reassigned each iteration
NET-4466 Fix S6966 FP: Do not suggest a non-awaitable overload resolved via speculative rebind
NET-4546 Fix S6669 FP: overridden "format" rule parameter is ignored
NET-4556 Fix S1128 FP: SafeVisit abort silently drops necessary usings
NET-4634 Fix S9022 FP: Generic identity pass-through wrapper not implementing IEnumerable misclassified as a reshaping boundary
NET-4639 Fix S8717 FP: EF6 and EF Core referenced in the same compilation (in-progress migration)
False Negative
NET-4256 Fix S9022 FN: Include on owned-type navigation not detected as redundant
NET-4532 Fix S9022/S9023 FN: rule stays silent when the Include is used in a comparison, cast, or other common expression
NET-4541 Fix S5542 FN: Detect weak RSA signature padding
Bug
NET-4571 Fix AD0001: NRE in DoNotOverwriteCollectionElements
NET-4587 Fix AD0001: ArgumentNullException in ReleaseCorrectReaderWriterLockBase (S7131)
NET-4588 Fix AD0001: ArgumentNullException in FirstSingleShouldBeUsedOnNonEmptyCollectionBase (S7130)
NET-4636 Fix S6966 AD0001: NullReferenceException on null-conditional calls followed by an indexer
Maintenance
NET-4370 Drop backward compatibility with S4NET below 5.2
NET-4540 Update MSTest to 4.4.0
NET-4550 Bump version to 10.35
NET-4555 Update SonarSource/sonar-scanner-engine monorepo to v13.11.0.5929
NET-4558 Create SLCORE ticket instead of SLVSCODE and SLI on release
NET-4579 ShimLayer Generator: Remove old BasicBlock and ControlFlowBranch
NET-4580 Update dependency Microsoft.NET.Test.Sdk to 18.10.0
NET-4596 Update dependency org.codehaus.mojo:build-helper-maven-plugin to v3.6.2
NET-4597 Update dependency Verify.MSTest to 32.0.1
NET-4622 Update SonarSource/sonar-scanner-engine monorepo to v13.13.0.6016
NET-4628 Update dependency Microsoft.NET.Test.Sdk to 18.10.1
NET-4631 Update MSTest to 4.4.1
NET-4632 Harden S1144: internal-type usage scan no longer trusts partial SafeVisit walks
NET-4637 Update protocolbuffers/protobuf monorepo to v4.36.2
NET-4663 Restore sonar-csharp-enterprise-plugin minsize to 6200000
10.34.0.3385
Release notes - .NET Analyzers - 10.34
Feature
NET-4133 Implement rule S9023: "Include" calls discarded by query reshaping should be fixed
False Positive
NET-3281 Fix S1192 FP: should not raise on DBContext model configuration
NET-4317 Fix S2325 FP: Do not raise on ConfigureServices in classes decorated with [LambdaStartup]
NET-4419 Fix S2737 FP: Do not report known temporary-context rethrow boundaries
NET-4421 Fix S6607 FP: Indexed LINQ Where after OrderBy
NET-4463 Fix S8747 FP: Do not raise when a defaultValue backfills existing NULLs before narrowing to non-nullable
NET-4506 Fix S6967 FP: Recognize manual DataAnnotations validation
NET-4507 Fix S8969 FP: Don't raise in Razor files
False Negative
NET-1883 Files added as symbolic links are not analyzed
NET-4249 Fix S9022 FN: Include before a terminal aggregate/scalar operator not detected as dead code
NET-4379 Fix S2259 FN: void compound assignment operators not flagged as dereference
NET-4383 Fix S9022 FN: Include on a navigation re-projected directly by a later Select/SelectMany is not detected as redundant
NET-4443 Fix S2068 FN: Scope the value passed to the secret-exclusion classifier to the candidate secret
NET-4496 Fix S8949 FN: self-recursion suppression also hides calls already recursive before the suggested fix
NET-4500 Fix S9022 FN: ThenInclude consumed only through a nested Select's rebound element parameter is not detected as redundant
Bug
NET-4483 Fix S3459 FP: Public writable properties in private nested types
Maintenance
NET-4472 Remove S1264 from the C# Sonar way profile
NET-4474 Remove S2692 from the C# Sonar way profile
NET-4480 Remove S3249 from the C# Sonar way profile
NET-4481 Remove S6670 from the C# Sonar way profile
NET-4482 Remove S3885 from the C# Sonar way profile
10.33.0.1635
Release notes - .NET Analyzers - 10.33
Feature
NET-4312 Update RSPEC before 10.33 release
NET-4254 Implement rule S9129: "Include" and "ThenInclude" chains of reference navigations should be merged into a single "Include" call
False Positive
NET-1777 Fix S101 FP: Lower case character after number
NET-4245 Fix S107 FP: should not raise for parameters marked with dependency-injection attributes
Maintenance
NET-4184 Duplicate telemetry key exception when multiple projects report the same non-counter telemetry value
10.32.0.713
Release notes - .NET Analyzers - 10.32
Feature
NET-4132 Implement rule S9022: Redundant "Include" calls should be removed
NET-4215 Implement rule S9118: Default values should be compatible with their entity property type
NET-4240 Update RSPEC before 10.32 release
False Positive
NET-1322 Fix S2857 FP: Do not raise in constant string interpolation when string is in square brackets
NET-1468 Fix S6966 FP: should not raise when inside lock
NET-1598 Fix S1125 FP: dynamic and custom nullable structs with conversion to bool are compliant
NET-4233 Fix S8733 FP: AsSplitQuery/AsSingleQuery set in a different statement than the colliding Includes goes undetected
NET-4297 Fix S8717 FP: EFCore DBFirst Scaffold
10.31.0.145097
Release notes - .NET Analyzers - 10.31
Feature
NET-3865 Implement S8733: Potential Cartesian Explosion
NET-3875 Implement rule S8718: Client-evaluated default values should use database functions
NET-4087 Use shared secret exclusion patterns in hardcoded secrets rules
NET-4211 Update RSPEC before 10.31 release
False Positive
NET-1922 S1144 FP: When registering a service with Microsoft.Extensions.DependencyInjecion framework
NET-3928 Fix S3267 FP: Should not raise on EntityFramework IQueryables
NET-4205 Fix S1244 FP: should not raise on NaN check via x.Equals(double.NaN)
10.30.0.144632
Release notes - .NET Analyzers - 10.30
Feature
NET-1536 Implement rule S8970: Null-forgiving operators should not be used when nullable warnings are disabled
NET-3436 Implement rule S8949: Use the overload that accepts a CancellationToken
NET-3810 Fix: Protobuf Importer logs debug on excluded files
NET-3877 Implement rule S8747: Migrations should not narrow column types without converting existing data
NET-4091 Implement rule S8969: Null-forgiving operators should not be redundant
NET-4120 Update RSPEC before 10.30 release
False Positive
NET-1541 Fix S3459 FP: support classes marked with [AutoConstructor] attribute
NET-1583 Fix S6967 FP: Raises when model has no validation attributes
NET-1840 Fix S3903 FP: top-level statements and partial Program in separate file
NET-4059 Improve precision of S8949 (CancellationTokenShouldBeUsed) - umbrella
NET-4191 Fix S3169 FP: Should not raise in Azure Cosmos
False Negative
NET-3819 Fix S1244 FN: Should report on Double.Equals
Bug
NET-4107 Fix S4026 Race Condition
10.29.0.143774
Release notes - .NET Analyzers - 10.29
Feature
NET-3997 Move S6444 out of hotspot
NET-4060 Update RSPEC before 10.29 release
False Positive
NET-1626 Fix S6444 FP: REGEX_DEFAULT_MATCH_TIMEOUT
False Negative
NET-3920 Fix S2971 FN: Should raise on EntityFramework IQueryables
NET-3921 Fix S1155 FN: Should raise on EntityFramework IQueryables
NET-3922 Fix S3981 FN: Should raise on EntityFramework IQueryables
NET-3924 Fix S3169 FN: Should raise on EntityFramework IQueryables
10.28.0.143324
Release notes - .NET Analyzers - 10.28
Feature
NET-1990 S100/S101: Configuration for custom acronyms
NET-2280 New Rule T0048: Avoid
is not { } valueNET-3802 Update RSPEC before 10.28 release
NET-3818 Change Protobuf Info message to Debug
NET-3820 Coverage warnings should surface as Analysis Warnings
NET-3827 Create RSPEC for S8717: Multiple "[Key]" attributes should not be used to define a composite key
NET-3843 Implement rule S8717: Multiple "[Key]" attributes should not be used to define a composite key
NET-3949 Modify rule S2696: add fix guidance, compliant example, and exceptions
NET-3950 Modify rule S1135: add compliant example and fix guidance
NET-3951 Modify rule S108: give the C# page its own code examples
NET-3952 Modify rule S1133: add rationale, fix guidance, code examples
NET-3953 Modify rule S3251: add compliant example, fix guidance, and exceptions
NET-3967 Move S1313 out of hotspot
NET-3969 Move S2077 out of hotspot
NET-3972 Move S2092 and S3330 out of hotspot
NET-3973 Move S2245 out of hotspot
NET-3975 Move S2257 out of hotspot
NET-3976 Move S4036 out of hotspot
NET-3978 Move S4502 out of hotspot
NET-3980 Move S4507 out of hotspot
NET-3982 Move S5122 out of hotspot
NET-3983 Move S5332 out of hotspot
NET-3993 Move S5443 out of hotspot
NET-3995 Move S5753 out of hotspot
NET-3996 Move S5766 out of hotspot
NET-3998 Move S6640 out of hotspot
NET-4000 Move S4790 out of hotspot
NET-4001 Move S5693 out of hotspot
NET-4008 Change S1313 message
NET-4009 Change S2257 message
NET-4010 Change S4036 message
NET-4011 Change S2077 message
False Positive
NET-3564 Fix FP S6966: Do not raise for methods for SqlDataReader.IsDBNull/GetFieldValue
NET-3808 Fix S4260 FP: Don't raise on extension properties
NET-3821 Fix S1244 FP: Should not raise on comparison to 0
NET-3825 Fix S2221 FP: Do not raise on async void
NET-3878 Fix S3358 FP: Suggesting to extract ternary from EF Core select
NET-3914 Fix T0044 FP: Should not raise on locator annotaitons
NET-3926 Fix S6608 FP: Should not raise inside expression tree
NET-3927 Fix S6603 FP: Should not raise inside expression tree
NET-3932 S2068: Do not raise on @paramName and $paramName
False Negative
NET-1673 Fix S4790 FN: default parameters
NET-2846 Fix S1117 FN: Extensions, Partial Events
... (truncated)
10.27.0.140913
Release notes - .NET Analyzers - 10.27
Feature
NET-1285 S2629: Add custom message for Log4Net and Castle.Core
NET-3666 Deprecate S5042 and move it from HotSpots to Code Smell
NET-3783 Update RSPEC before 10.27 release
False Positive
NET-2696 Fix S4260 FP: Extension Properties always raise
False Negative
NET-230 Fix S4056 FN: SpecifyIFormatProviderOrCultureInfo for C#13 compatibility
NET-2692 Fix S2190 FN: Recursive extension properties
NET-2705 Fix S3343 FN: Partial Constructor with attribute in definition
NET-2732 Fix S1172 FN: Extension blocks
NET-2745 Fix S4144 FN: Extension Members
NET-2829 Fix S3241 FN: Extension methods and extension blocks
NET-3541 Fix S1117 FN: add CatchDeclaration coverage and adopt LocalDeclarationKinds
10.26.0.140279
Release notes - .NET Analyzers - 10.26
Feature
NET-3694 Update RSPEC before 10.26 release
False Positive
NET-2346 Fix S1854 FP: Variable used after another assignment in finally
NET-2347 Fix S1168 FP: Do not report on value types
NET-3698 Fix S1210 FP: file-scoped types should be exempt
False Negative
NET-1265 Fix S2930 FN: raise issues on non-disposed RegistryKeys
NET-2685 Fix S3604 FN: Field Keyword, Partial Constructors, NullConditional Assignment
NET-2812 Fix S4275 FN: Field Keyword
NET-2999 Fix S6672 FN: Mismatch in primary constructor is not recognized
10.25
?
Feature
sonar.cs.cobertura.reportsPathsparameterFalse Positive
10.24
This release brings a batch of false negative fixes and analyzer crash fixes.
Bug Fixes
False Positives
False Negatives
10.23
This release brings a bunch of fixes! Enjoy.
Bug Fixes
False Positives
False Negatives
10.22
Hello everyone,
This release brings 4 new rules to help developers transition to C# 14, and a bunch of false positive fixes.
New rules
False Positive
Bugs
Other
10.21
### Bug
Feature
False Positive
10.20
This release brings 9 precision improvements — 7 false positive fixes and 2 false negative fixes — across rules S1116, S1144, S1210, S1643, S1854, S2365, S3254, S3265, and S127. It also promotes S2068 and S6418 from Security Hotspot to Vulnerability, making them visible directly in the IDE, and removes S3256 from the Sonar Way quality profile.
Changes
False Positive
False Negative
Rule specification
Maintenance
10.19
Documentation
False Positive
False Negative
Task
Bug
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)