Skip to content

Subscriptions docs suggestions - #4435

Merged
yaacovCR merged 3 commits into
17.x.xfrom
Urigo-patch-1
Jun 9, 2026
Merged

yaacovCR merged 3 commits into
17.x.xfrom
Urigo-patch-1

Conversation

@Urigo

@Urigo Urigo commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Adding some suggestions to the subscriptions section:

As mentioned in this comment, the graphql-subscriptions library is not maintained (reference) I've made a change to recommend another library for the solution.

In order to move this our of draft, @enisdenjo @ardatan I believe we'll need to publish a README specifically for that library.

I've also changed the comment about WebSockets and SSE, I'm not sure if we want to say that most people use WebSockets?

@Urigo
Urigo requested a review from enisdenjo June 10, 2025 16:14
@benjie

benjie commented Jun 19, 2025

Copy link
Copy Markdown
Member

Is it unmaintained? According to npm its last release was 7 months ago:

@enisdenjo

enisdenjo commented Jun 19, 2025 •

Copy link
Copy Markdown
Member

v3 was pending release for like 3 years... Issues are also largely unanswered https://github.com/apollographql/graphql-subscriptions/issues.

@Urigo
Urigo marked this pull request as ready for review August 19, 2025 16:19
@Urigo
Urigo requested a review from a team as a code owner August 19, 2025 16:19
@yaacovCR
yaacovCR changed the base branch from 16.x.x to 17.x.x June 9, 2026 18:56
@vercel

vercel Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
graphql-js Ready Ready Preview, Comment Jun 9, 2026 7:57pm

Request Review

@yaacovCR
yaacovCR merged commit 3b44d5d into 17.x.x Jun 9, 2026
44 checks passed
@yaacovCR
yaacovCR deleted the Urigo-patch-1 branch June 9, 2026 20:00
yaacovCR added a commit that referenced this pull request Jun 15, 2026
## v17.0.0 (2026-06-15)

#### New Feature 🚀
* [#4819](#4819) feat: graduate directives on directives ([@yaacovCR](https://github.com/yaacovCR))

#### Bug Fix 🐞
* [#4799](#4799) fix: raise request error on invalid fragment variables ([@yaacovCR](https://github.com/yaacovCR))
* [#4800](#4800) fix: apply directives when SDL contains type definitions and extensions with directives ([@yaacovCR](https://github.com/yaacovCR))
* [#4564](#4564) OneOf Inhabitability ([@jbellenger](https://github.com/jbellenger))
* [#4814](#4814) fix(KnownDirectivesRule): locations for input field arguments in extensions ([@yaacovCR](https://github.com/yaacovCR))
* [#4726](#4726) feat(validation): reject directive definition cycles ([@yaacovCR](https://github.com/yaacovCR))
* [#4815](#4815) Revert "feat(validation): reject directive definition cycles (#4726)" ([@yaacovCR](https://github.com/yaacovCR))

#### Docs 📝
<details>
<summary> 11 PRs were merged </summary>

* [#4790](#4790) docs: minor diagnostics doc comment improvements ([@yaacovCR](https://github.com/yaacovCR))
* [#4791](#4791) fix: docs: polish diagnostics comments further ([@yaacovCR](https://github.com/yaacovCR))
* [#4793](#4793) docs: further improve general execution and tracing docs ([@yaacovCR](https://github.com/yaacovCR))
* [#4802](#4802) docs: correct extension field comments - v17 ([@yaacovCR](https://github.com/yaacovCR))
* [#4805](#4805) docs: publish fixed extensions comments ([@yaacovCR](https://github.com/yaacovCR))
* [#4807](#4807) docs: add prettier for jsdoc examples ([@yaacovCR](https://github.com/yaacovCR))
* [#4435](#4435) Subscriptions docs suggestions ([@Urigo](https://github.com/Urigo))
* [#4811](#4811) docs: fix a few indentations inside string literals ([@yaacovCR](https://github.com/yaacovCR))
* [#4813](#4813) internal: docs update ([@yaacovCR](https://github.com/yaacovCR))
* [#4820](#4820) docs: document `@experimental_disableErrorPropagation` ([@yaacovCR](https://github.com/yaacovCR))
* [#4817](#4817) docs: post 17.rc-0 update ([@yaacovCR](https://github.com/yaacovCR))
</details>

#### Polish 💅
<details>
<summary> 2 PRs were merged </summary>

* [#4809](#4809) internal: use prettier for non-generated website files ([@yaacovCR](https://github.com/yaacovCR))
* [#4812](#4812) polish: fix stream test cases ([@yaacovCR](https://github.com/yaacovCR))
</details>

#### Internal 🏠
<details>
<summary> 6 PRs were merged </summary>

* [#4795](#4795) chore: move website publishing from 16.x.x to 17.x.x ([@yaacovCR](https://github.com/yaacovCR))
* [#4796](#4796) internal: fix broken npm/deno deployments ([@yaacovCR](https://github.com/yaacovCR))
* [#4797](#4797) ci: update GitHub Actions versions ([@yaacovCR](https://github.com/yaacovCR))
* [#4806](#4806) internal: update frontmatter ([@yaacovCR](https://github.com/yaacovCR))
* [#4808](#4808) intenral: fix ci badge ([@yaacovCR](https://github.com/yaacovCR))
* [#4810](#4810) internal: add prettier:examples to lint-staged ([@yaacovCR](https://github.com/yaacovCR))
</details>

#### Committers: 3
* James Bellenger([@jbellenger](https://github.com/jbellenger))
* Uri Goldshtein([@Urigo](https://github.com/Urigo))
* Yaacov Rydzinski ([@yaacovCR](https://github.com/yaacovCR))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants