Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the gapic-generator-typescript tool version from v5.5.0 to v5.7.1 in librarian.yaml, updating its package URL and checksum accordingly. There are no review comments to address, and I have no additional feedback to provide.
feywind
force-pushed
the
chore/update-generator-v5.7.1
branch
from
October 20, 2026 16:44
f189b46 to
9885223
Compare
feywind
marked this pull request as ready for review
October 20, 2026 17:36
shivanee-p
approved these changes
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates gapic-generator-typescript in librarian.yaml from v5.5.0 to v5.7.1.
Impact
Librarian uses gapic-generator-typescript v5.7.1 when generating client libraries.
Changes
tools.pnpmentry forgapic-generator-typescriptinlibrarian.yamltogapic-generator-v5.7.1(including resumable upload client generation from feat(generator): select resumable upload methods #9284 and feat(generator): generate resumable upload client methods #9285,.gitignoretemplate updates from chore: update package.json and .gitignore across packages #9378, and ESM.jsdoc.jsontemplate updates from fix(generator): use .jsdoc.json with build/esm/src in ESM template #9523).package-lock.jsonfrompackages/*/.gitignoreto match the updated.gitignore.njktemplates from chore: update package.json and .gitignore across packages #9378 (gapic-generator-v5.6.0).Testing
gapic-generator-v5.7.1.tar.gzrelease archive.Alternatives
gapic-generator-v5.5.0was considered, but newer generator fixes (such as.jsdoc.jsonsupport for ESM packages and resumable upload support) would not be applied during Librarian generation.