Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the @google-cloud/common dependency to version ^8.2.0 across several package files and librarian.yaml. However, the reviewer notes that version 8.2.0 contains a bug that percent-encodes {{projectId}} and breaks token replacement. To avoid this issue, it is highly recommended to bump the dependency floor directly to ^8.2.1 instead of ^8.2.0.
| }, | ||
| "dependencies": { | ||
| "@google-cloud/common": "^8.0.0", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@google-cloud/common": "^8.0.0", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
| }, | ||
| "dependencies": { | ||
| "@google-cloud/common": "^8.0.0", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
| }, | ||
| "dependencies": { | ||
| "@google-cloud/common": "^8.0.0", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
| }, | ||
| "devDependencies": { | ||
| "@google-cloud/common": "^8.0.0", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
| "@babel/helpers": "7.27.6", | ||
| "@babel/traverse": "7.27.7", | ||
| "@google-cloud/common": "^8.0.0", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
| default_version: v1 | ||
| dependencies: | ||
| '@google-cloud/common': ^6.0.0 | ||
| '@google-cloud/common': ^8.2.0 |
There was a problem hiding this comment.
| default_version: v3 | ||
| dependencies: | ||
| '@google-cloud/common': ^6.0.0 | ||
| '@google-cloud/common': ^8.2.0 |
There was a problem hiding this comment.
| }, | ||
| "dependencies": { | ||
| "@google-cloud/common": "^8.0.1", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
| }, | ||
| "dependencies": { | ||
| "@google-cloud/common": "^8.0.1", | ||
| "@google-cloud/common": "^8.2.0", |
There was a problem hiding this comment.
To prevent package managers from resolving to the buggy @google-cloud/common@8.2.0 release (which percent-encodes {{projectId}} and breaks token replacement), the dependency floor should be set directly to ^8.2.1 instead of ^8.2.0.
| "@google-cloud/common": "^8.2.0", | |
| "@google-cloud/common": "^8.2.1", |
17e18ef to
f86a1ff
Compare
f86a1ff to
132432c
Compare
Description
This change upgrades the @google-cloud/common dependency floor across consumer packages.
Impact
Consumers receive URI path encoding and project ID token handling fixes.
Changes
"@google-cloud/common"dependency floor acrosshandwritten/{bigquery,cloud-profiler,error-reporting,google-cloud-dns,logging,logging-bunyan,logging-winston,spanner},packages/{google-cloud-speech,google-cloud-translate}, andlibrarian.yaml.#9668) is now merged onmain(14b0cc6a45). Once Release-Please PR#9684merges and publishes@google-cloud/common@8.2.2to npm, this PR will be bumped to^8.2.2withpnpm-lock.yamlregenerated.Testing
GIT_DIFF_ARG=origin/main node ./bin/linter.mjs --strictpasses with zero errors and zero warnings.handwritten/bigquery(550 passing) andhandwritten/google-cloud-dns(99 passing) under both Node.js andJS_RUNTIME=bun.handwritten/bigqueryandhandwritten/bigquery-storageagainstnode-testbench-sandbox-789145.Alternatives
#9684publishes@google-cloud/common@8.2.2to npm would resolve@google-cloud/common@8.2.1from npm, which lacks#9668; keeping this PR in Draft until@google-cloud/common@8.2.2is released avoids that regression.