[shivanee-p]

This adds an enableTelemetryLogging client option to gax, alongside the existing enableTelemetryTracing. Logging is gated behind an experimental env var, and the resolved tracing and logging flags are passed to each call through CallSettings.otherArgs

Key Changes

• Renamed checkTelemetryEnabled to checkTracingEnabled to make room for a logging check. Updated the callers in createApiCall.ts and the export in index.ts
• Added checkLoggingEnabled(settings?). Logging is enabled only when:
  • GOOGLE_SDK_NODE_EXPERIMENTAL_LOGGING is true/1, and
  • either GOOGLE_SDK_NODE_ENABLE_LOGGING is true/1, or, if that env var is unset, enableTelemetryLogging: true is set on the settings or on otherArgs.
  • GOOGLE_SDK_NODE_ENABLE_LOGGING always overrides the client option when it is set.
• Added enableTelemetryLogging?: boolean to ClientOptions, GrpcClientOptions, CallOptions and CallSettings
• When tracing or logging is requested, otherArgs now includes internalMethodName, enableTelemetryTracing and enableTelemetryLogging

[shivanee-p]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces telemetry logging capabilities to the Google API Extensions (gax) library, controlled by the GOOGLE_SDK_NODE_EXPERIMENTAL_LOGGING and GOOGLE_SDK_NODE_ENABLE_LOGGING environment variables or the enableTelemetryLogging client option. It also renames existing tracing-related telemetry functions to distinguish them from the new logging features. Feedback on the changes highlights a critical issue in gax.ts where the parameter-shifting logic in constructSettings was not updated to handle the new enableTelemetryLogging and _legacyTelemetryInfo parameters when status is omitted, which will cause incorrect parameter mapping and test failures.

[gemini-code-assist]

Code Review

This pull request introduces telemetry logging capabilities to the GAX client, adding enableTelemetryLogging configuration options across client options, call settings, and environment variables. However, critical parameter mismatches were identified in both fallback.ts and grpc.ts when calling the imported constructSettings function. Because the apiName parameter was omitted, subsequent arguments like enableTelemetryTracing and enableTelemetryLogging are misaligned and mapped incorrectly.

[shivanee-p]

Note: the error from the breaking-change-check is a false positive and not related to the changes in this PR