Skip to content

Prove the numerical bounds used by split operations - #3840

Open
joshlf wants to merge 1 commit into
Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7from
Gytt7syk4w4f52xlmszabgwlaiofsu7p6
Open

joshlf wants to merge 1 commit into
Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7from
Gytt7syk4w4f52xlmszabgwlaiofsu7p6

Conversation

@joshlf

@joshlf joshlf commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Factor the split-length calculation and zero-padding decision into proved
helpers used by the production pointer paths. A Rust assertion harness
compares complete sizes with the independent reference and checks physical
tail containment.

Prove counts, bounds and disjoint numerical intervals, including empty and
zero-sized tails, under the visible witness and containment guards.
Pointer validity, provenance and access permissions remain separate Rust
obligations. Refresh UI diagnostics for the shifted source lines.

Agent-authored-by: AI agent acting on joshlf's behalf


Latest Update: v8 — Compare vs v7

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v7 v6 v5 v4 v3 v2 v1 Base
v8 vs v7 vs v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v7 vs v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v5 vs v4 vs v3 vs v2 vs v1 vs Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6 && git checkout -b pr-Gytt7syk4w4f52xlmszabgwlaiofsu7p6 FETCH_HEAD

Checkout

git fetch origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gytt7syk4w4f52xlmszabgwlaiofsu7p6

Stacked PRs enabled by GHerrit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:24:43.065371Z 11914d0 PR opened
🔒 Security Review ✅ Completed 2026-10-08T10:25:11.764579Z 11914d0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This was referenced Oct 8, 2026
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from 11914d0 to 8b0dc59 Compare October 9, 2026 00:08
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 7.57576% with 61 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7@4e8a022). Learn more about missing BASE report.

Files with missing lines Patch % Lines
zerocopy/src/split_at.rs 6.45% 58 Missing ⚠️
zerocopy/src/layout/tail_checks.rs 0.00% 2 Missing ⚠️
zerocopy/src/layout/tail_transform_checks.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##             Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7    #3840   +/-   ##
====================================================================
  Coverage                                     ?   54.02%           
====================================================================
  Files                                        ?       27           
  Lines                                        ?     4235           
  Branches                                     ?        0           
====================================================================
  Hits                                         ?     2288           
  Misses                                       ?     1947           
  Partials                                     ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Factor the split-length calculation and zero-padding decision into proved
helpers used by the production pointer paths. A Rust assertion harness
compares complete sizes with the independent reference and checks physical
tail containment.

Prove counts, bounds and disjoint numerical intervals, including empty and
zero-sized tails, under the visible witness and containment guards.
Pointer validity, provenance and access permissions remain separate Rust
obligations. Refresh UI diagnostics for the shifted source lines.

gherrit-pr-id: Gytt7syk4w4f52xlmszabgwlaiofsu7p6
Agent-authored-by: AI agent acting on joshlf's behalf
@joshlf
joshlf force-pushed the Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7 branch from 4e8a022 to 79ea0f5 Compare October 9, 2026 02:21
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from 8b0dc59 to 18cc2e3 Compare October 9, 2026 02:21
@joshlf
joshlf force-pushed the Gpvecn2gjh2spv5hy32nqxdlgiqp5jus7 branch from 79ea0f5 to ddf7886 Compare October 10, 2026 00:00
@joshlf
joshlf force-pushed the Gytt7syk4w4f52xlmszabgwlaiofsu7p6 branch from 18cc2e3 to 945b8c9 Compare October 10, 2026 00:00
@joshlf joshlf changed the title Prove split lengths and non-overlapping numerical regions Prove the numerical bounds used by split operations Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants