Repository navigation
Conversation
Python-mode model_dump left Decimal/datetime/Enum values that break Event.output JSON serialization despite docs promising JSON-safe dicts.
9 tasks
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
Merge #6750 BREAKING CHANGE: Coerces validated schema inputs and outputs (Decimal, datetime, UUID, Enum) to JSON primitives (str, int) via mode='json'. This affects in-memory node outputs as well as llm_agent output_key state and agent_tool results (bare Decimal dumps to str), as well as node inputs when a dict input_schema is used (such as with parameter_binding='node_input'). Additionally, validating against a dict or types.Schema now raises a hard failure (PydanticSerializationError) on values that Pydantic cannot coerce, where un-coercible values passed through before. Fixes #6747 PiperOrigin-RevId: 991903366
Collaborator
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
Merge #6750 BREAKING CHANGE: Coerces validated schema inputs and outputs (Decimal, datetime, UUID, Enum) to JSON primitives (str, int) via mode='json'. This affects in-memory node outputs as well as llm_agent output_key state and agent_tool results (bare Decimal dumps to str), as well as node inputs when a dict input_schema is used (such as with parameter_binding='node_input'). Additionally, validating against a dict or types.Schema now raises a hard failure (PydanticSerializationError) on values that Pydantic cannot coerce, where un-coercible values passed through before. Fixes #6747 PiperOrigin-RevId: 991959930
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_dump(mode="json")when converting validated node schema results to dicts sowhen_used="json"serializers run and values likeDecimal/datetime/ non-strEnumstay JSON-serializableBaseNode._to_serializable,validate_node_data,validate_schema, and resume-response dumping with the documented Event.output contractFixes #6747
Test plan
uv run pytest tests/unittests/utils/test_schema_utils.py tests/unittests/workflow/utils/test_rehydration_utils.py -q(95 passed)json.dumpsraisedTypeErroronDecimal; after fix returns{"price": {"amount": 29.99}}