Skip to content

feat(skills): add antares-builder consumer skill - #404

Open
rmojica-godaddy wants to merge 6 commits into
mainfrom
rmb/skill
Open

rmojica-godaddy wants to merge 6 commits into
mainfrom
rmb/skill

Conversation

@rmojica-godaddy

@rmojica-godaddy rmojica-godaddy commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add antares-builder, a consumer-facing agent skill for building, adapting, and reviewing React interfaces with the public @godaddy/antares API. It guides agents through choosing components by behavior, composing complete interfaces, and verifying accessibility and framework integration against the consumer's installed version.

Changes Made

  • Add a focused SKILL.md workflow with references loaded as needed, published at skills/antares-builder/ (consumer installation path) rather than under .agents/skills/, which stays reserved for contributor tooling. Removed the .claude/skills/antares-builder symlink accordingly.
  • Document component selection, composition, forms and validation, overlays, responsive layout, styling, charts, and consumer setup.
  • Add metadata.version/metadata.author to the SKILL.md frontmatter.
  • Harden Step 2 guidance so the agent verifies that a recommended component (not just a no-match fallback) still exists in the installed Antares version's public exports/types — the decision tree and examples describe one point in Antares's release history, so a newer install may add components it doesn't list yet, and an older install may lack one it recommends or expose different props.
  • Add an eval suite (evals/evals.json, now 16 cases, evals/trigger-evals.json, and five supporting fixtures) built with skill-creator.
  • Add 3 new eval cases (14–16) plus three "installed type declaration" fixtures that simulate a newer install with an unlisted component (Combobox), an older install missing a documented component (Skeleton), and a component with changed props (ProgressBar) — proving the installed public API wins over stale skill guidance in all three cases.
  • Flesh out the "AI Agent Skills" section in packages/@godaddy/antares/README.mdx with the same install/agent-selection guidance already in the root README.md.
  • Add apm.yml at the repo root describing the published skills/ collection for Agent Package Manager (APM), including license, keywords, type: skill, and includes: auto per the published APM manifest schema.

Installation for consumers

Run the Skills CLI from the consumer application's directory (Node.js 22.20 or later).

After this PR is merged into main:

npx skills add godaddy/antares --skill antares-builder

Or, with Agent Package Manager (APM) installed:

apm install godaddy/antares --skill antares-builder --target codex

Select the coding agents to install to when prompted. Installation is scoped to the current project by default. To target an agent explicitly:

# Codex
npx skills add godaddy/antares --skill antares-builder --agent codex

# Claude Code
npx skills add godaddy/antares --skill antares-builder --agent claude-code

Add --global to install for the current user across projects.

To try the skill from this PR before merge:

npx skills add https://github.com/godaddy/antares/tree/rmb/skill/skills/antares-builder --skill antares-builder

The skill supplies agent instructions and references; consumers install @godaddy/antares separately using their application's package manager. Example request after installation: "Build a responsive settings form with Antares, including validation and a confirmation dialog."

Test Plan

  • git diff --cached --check passed before committing.

  • Verified all reference links and the skill's directory move resolve correctly from the new skills/antares-builder/ location.

  • With Node 24.14.1, registry validation, package formatting, Syncpack lint, and typecheck passed via the repo's pre-commit hook.

  • Ran a full with/without-skill benchmark via skill-creator, across all 16 eval cases (32 executions + grading), covering both the original 13 component-composition/review scenarios and the 3 new version-compatibility cases:

    Metric With Skill Without Skill Delta
    Pass rate 100% (48/48 assertions) 56% +44 pts
    Time 336.9s 100.5s +236.4s
    Tokens 76,245 50,304 +25,940

    With the skill: 16/16 cases passed 100% of their assertions. Without it, the agent repeatedly invented components/props that don't exist in the real package (Toggle, IconButton, FlexBox, FormGroup, Dialog/DialogTrigger, SearchField, Stack, and label/title/errorMessage props on components that are actually children-based), and in two cases (FAQ accordion+tabs, product grid) didn't use any Antares component at all despite the prompt explicitly requesting one. The new compatibility cases (14–16) confirm the skill correctly prioritizes a consumer's installed API over its own (potentially stale) guidance in both directions — adopting a newer, undocumented Combobox export, and avoiding a Skeleton recommendation when the installed version predates it.

Checklist

  • Added skill documentation and focused references.
  • Moved the published skill to skills/antares-builder/, separate from contributor tooling in .agents/skills/.
  • Reviewed staged scope; the eval suite (16 cases) is an intended deliverable, validated against a full with/without-skill benchmark (100% vs 56% pass rate).
  • Added version-compatibility eval coverage (newer/older installs, changed props) proving the installed API takes priority over stale skill guidance.
  • Documented consumer installation (Skills CLI and APM) and pre-merge preview commands.
  • Added apm.yml for APM-based installation.
  • Full repository pre-commit checks pass.
  • No package runtime changes or changeset required.

Copilot AI balanced review requested due to automatic review settings October 20, 2026 15:37
@changeset-bot

changeset-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 742cc73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Docs Site Preview

Preview URL: https://godaddy.github.io/antares/pr-404-site/

Preview will be automatically deleted when this PR is closed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved documentation errors could misdirect consumers during API discovery and component selection.

2 open issues
What changed in this PR

Adds a consumer-facing skill for building and reviewing React interfaces with Antares’s public API, without changing package runtime code.

Changes:

  • Defines a workflow for component selection, composition and verification.
  • Adds focused references for setup, accessibility, forms, layout and charts.
File Description
.agents/​skills/​antares-builder/​SKILL.md Defines the consumer workflow.
.agents/​skills/​antares-builder/​references/​setup.md Documents imports and framework integration.
.agents/​skills/​antares-builder/​references/​layout-and-styling.md Explains responsive layout and styling.
.agents/​skills/​antares-builder/​references/​composition-patterns.md Documents component composition and interactions.
.agents/​skills/​antares-builder/​references/​component-decision-tree.md Maps interface needs to components.
.agents/​skills/​antares-builder/​references/​charts.md Covers chart APIs and accessibility.

Review effort: Balanced

Comment thread .agents/skills/antares-builder/SKILL.md Outdated
Comment thread .agents/skills/antares-builder/references/component-decision-tree.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

📚 Storybook Preview

Preview URL: https://godaddy.github.io/antares/pr-404-storybook/

Preview will be automatically deleted when this PR is closed.

Adds evals/evals.json (12 cases) and trigger-evals.json for the
antares-builder skill, built with skill-creator and validated against
a full with/without-skill benchmark.

Fixes informed by that benchmark and by cross-checking guidance against
the real component source:
- Move focus to the first invalid field on a failed submission
  (fields-and-validation).
- Don't unmount a step/panel's stateful children (e.g. a Carousel) when
  switching steps - keep mounted, toggle visibility.
- Trim repeated "*Context is an advanced API" disclaimers into one
  general note.
- Describe PaginationDots as a passive current-page indicator with no
  ellipsis/page-omission support, matching its real implementation
  (resolves PR review comment on component-decision-tree.md).
- SKILL.md/setup.md: point API discovery at the real Antares repo
  instead of a dead anchor link (resolves PR review comment).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 21, 2026 14:54
Copilot AI previously approved these changes Oct 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The changes add guidance and evaluation assets without changing package runtime behavior, and no blocking correctness issues remain.

1 open issue
2 resolved since last review

Review effort: Balanced

Comment thread skills/antares-builder/evals/evals.json
rmojica-godaddy and others added 2 commits October 21, 2026 10:40
main merged a new Skeleton component (#396) after this branch diverged.
Add it to the skill instead of leaving it listed as an unsupported gap,
and point consumers at the skill from the package README:

- Remove Skeleton from component-decision-tree.md's API-gaps list and
  add it to the decision tree under information/feedback.
- Document composition-patterns.md guidance: match size/width/
  aspectRatio/rounding to the real layout, and mark the loading region
  with role="status"/aria-busy/aria-label since Skeleton itself is
  aria-hidden.
- Add eval 13 (profile-card loading state) validated with-skill and
  without-skill, 3/3 both configs - kept as a regression guard even
  though it didn't differentiate skill value in this run, since the
  library's own example already matches the pattern closely.
- Add an "AI Agent Skills" section to the antares package README,
  right after the Quick Start import examples, with the install
  command for antares-builder.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 21, 2026 16:14
Copilot AI dismissed their stale review, a newer Copilot review was requested October 21, 2026 16:14
Copilot AI previously approved these changes Oct 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

Only a minor documentation correction remains; these documentation and evaluation additions introduce no runtime changes.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread skills/antares-builder/references/charts.md
@rmojica-godaddy
rmojica-godaddy marked this pull request as ready for review October 21, 2026 16:49
@rmojica-godaddy
rmojica-godaddy requested a review from a team as a code owner October 21, 2026 16:49

@rmarkins-godaddy rmarkins-godaddy left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we looked at making this using APM and publishing it as an APM package so we can properly version our Agentic tools (skills, plugins, etc). ? https://microsoft.github.io/apm/quickstart/

Comment thread skills/antares-builder/SKILL.md
Comment thread .agents/skills/antares-builder/SKILL.md Outdated
Comment thread skills/antares-builder/SKILL.md
Comment thread packages/@godaddy/antares/README.mdx
Comment thread .agents/skills/antares-builder/SKILL.md Outdated
Comment thread skills/antares-builder/evals/evals.json
- Move antares-builder to skills/ at the repo root; remove the
  .agents/skills contributor symlink and .claude/skills consumer symlink
  so contributor tooling stays separate from the published collection.
- Add metadata.version/author to SKILL.md frontmatter.
- Extend Step 2 guidance so the agent verifies that a recommended
  component (not just a fallback) still exists in the installed Antares
  version, since the decision tree reflects one point in release history.
- Add 3 eval cases (14-16) plus installed-types fixtures proving the
  installed public API wins over stale skill guidance for a newer
  install with an unlisted component, an older install missing a
  documented component, and a component with changed props.
- Flesh out the "AI Agent Skills" section in the package README.mdx with
  install/agent-selection guidance matching the root README.
- Fill in apm.yml with license, keywords, type and includes per the
  published APM manifest schema.
Copilot AI balanced review requested due to automatic review settings October 23, 2026 16:44
Copilot AI dismissed their stale review, a newer Copilot review was requested October 23, 2026 16:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No blocking issues remain in the documentation, evaluation fixtures, or distribution setup, and the changes do not modify package runtime behavior.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants