Repository navigation
feat(skills): add antares-builder consumer skill - #404
rmojica-godaddy wants to merge 6 commits into
Conversation
|
Docs Site PreviewPreview URL: https://godaddy.github.io/antares/pr-404-site/ Preview will be automatically deleted when this PR is closed. |
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved documentation errors could misdirect consumers during API discovery and component selection.
2 open issues
What changed in this PR
Adds a consumer-facing skill for building and reviewing React interfaces with Antares’s public API, without changing package runtime code.
Changes:
- Defines a workflow for component selection, composition and verification.
- Adds focused references for setup, accessibility, forms, layout and charts.
| File | Description |
|---|---|
.agents/skills/antares-builder/SKILL.md |
Defines the consumer workflow. |
.agents/skills/antares-builder/references/setup.md |
Documents imports and framework integration. |
.agents/skills/antares-builder/references/layout-and-styling.md |
Explains responsive layout and styling. |
.agents/skills/antares-builder/references/composition-patterns.md |
Documents component composition and interactions. |
.agents/skills/antares-builder/references/component-decision-tree.md |
Maps interface needs to components. |
.agents/skills/antares-builder/references/charts.md |
Covers chart APIs and accessibility. |
Review effort: Balanced
📚 Storybook PreviewPreview URL: https://godaddy.github.io/antares/pr-404-storybook/ Preview will be automatically deleted when this PR is closed. |
Adds evals/evals.json (12 cases) and trigger-evals.json for the antares-builder skill, built with skill-creator and validated against a full with/without-skill benchmark. Fixes informed by that benchmark and by cross-checking guidance against the real component source: - Move focus to the first invalid field on a failed submission (fields-and-validation). - Don't unmount a step/panel's stateful children (e.g. a Carousel) when switching steps - keep mounted, toggle visibility. - Trim repeated "*Context is an advanced API" disclaimers into one general note. - Describe PaginationDots as a passive current-page indicator with no ellipsis/page-omission support, matching its real implementation (resolves PR review comment on component-decision-tree.md). - SKILL.md/setup.md: point API discovery at the real Antares repo instead of a dead anchor link (resolves PR review comment). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
main merged a new Skeleton component (#396) after this branch diverged. Add it to the skill instead of leaving it listed as an unsupported gap, and point consumers at the skill from the package README: - Remove Skeleton from component-decision-tree.md's API-gaps list and add it to the decision tree under information/feedback. - Document composition-patterns.md guidance: match size/width/ aspectRatio/rounding to the real layout, and mark the loading region with role="status"/aria-busy/aria-label since Skeleton itself is aria-hidden. - Add eval 13 (profile-card loading state) validated with-skill and without-skill, 3/3 both configs - kept as a regression guard even though it didn't differentiate skill value in this run, since the library's own example already matches the pattern closely. - Add an "AI Agent Skills" section to the antares package README, right after the Quick Start import examples, with the install command for antares-builder. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Have we looked at making this using APM and publishing it as an APM package so we can properly version our Agentic tools (skills, plugins, etc). ? https://microsoft.github.io/apm/quickstart/
- Move antares-builder to skills/ at the repo root; remove the .agents/skills contributor symlink and .claude/skills consumer symlink so contributor tooling stays separate from the published collection. - Add metadata.version/author to SKILL.md frontmatter. - Extend Step 2 guidance so the agent verifies that a recommended component (not just a fallback) still exists in the installed Antares version, since the decision tree reflects one point in release history. - Add 3 eval cases (14-16) plus installed-types fixtures proving the installed public API wins over stale skill guidance for a newer install with an unlisted component, an older install missing a documented component, and a component with changed props. - Flesh out the "AI Agent Skills" section in the package README.mdx with install/agent-selection guidance matching the root README. - Fill in apm.yml with license, keywords, type and includes per the published APM manifest schema.


Summary
Add
antares-builder, a consumer-facing agent skill for building, adapting, and reviewing React interfaces with the public@godaddy/antaresAPI. It guides agents through choosing components by behavior, composing complete interfaces, and verifying accessibility and framework integration against the consumer's installed version.Changes Made
SKILL.mdworkflow with references loaded as needed, published atskills/antares-builder/(consumer installation path) rather than under.agents/skills/, which stays reserved for contributor tooling. Removed the.claude/skills/antares-buildersymlink accordingly.metadata.version/metadata.authorto theSKILL.mdfrontmatter.evals/evals.json, now 16 cases,evals/trigger-evals.json, and five supporting fixtures) built withskill-creator.Combobox), an older install missing a documented component (Skeleton), and a component with changed props (ProgressBar) — proving the installed public API wins over stale skill guidance in all three cases.packages/@godaddy/antares/README.mdxwith the same install/agent-selection guidance already in the rootREADME.md.apm.ymlat the repo root describing the publishedskills/collection for Agent Package Manager (APM), includinglicense,keywords,type: skill, andincludes: autoper the published APM manifest schema.Installation for consumers
Run the Skills CLI from the consumer application's directory (Node.js 22.20 or later).
After this PR is merged into
main:Or, with Agent Package Manager (APM) installed:
Select the coding agents to install to when prompted. Installation is scoped to the current project by default. To target an agent explicitly:
Add
--globalto install for the current user across projects.To try the skill from this PR before merge:
The skill supplies agent instructions and references; consumers install
@godaddy/antaresseparately using their application's package manager. Example request after installation: "Build a responsive settings form with Antares, including validation and a confirmation dialog."Test Plan
git diff --cached --checkpassed before committing.Verified all reference links and the skill's directory move resolve correctly from the new
skills/antares-builder/location.With Node 24.14.1, registry validation, package formatting, Syncpack lint, and typecheck passed via the repo's pre-commit hook.
Ran a full with/without-skill benchmark via
skill-creator, across all 16 eval cases (32 executions + grading), covering both the original 13 component-composition/review scenarios and the 3 new version-compatibility cases:With the skill: 16/16 cases passed 100% of their assertions. Without it, the agent repeatedly invented components/props that don't exist in the real package (
Toggle,IconButton,FlexBox,FormGroup,Dialog/DialogTrigger,SearchField,Stack, andlabel/title/errorMessageprops on components that are actually children-based), and in two cases (FAQ accordion+tabs, product grid) didn't use any Antares component at all despite the prompt explicitly requesting one. The new compatibility cases (14–16) confirm the skill correctly prioritizes a consumer's installed API over its own (potentially stale) guidance in both directions — adopting a newer, undocumentedComboboxexport, and avoiding aSkeletonrecommendation when the installed version predates it.Checklist
skills/antares-builder/, separate from contributor tooling in.agents/skills/.apm.ymlfor APM-based installation.