Repository navigation
Conversation
The alpha part of the rgba and hsla regexes was `(?:0.[1-9]*)|[01]`. The unescaped `.` matches any character and `[1-9]*` forbids zeros in the fraction, so common CSS values such as `rgba(0,0,0,0.05)`, `0.50`, `0.0` and `1.0` were rejected while junk like `0a` or `0x` was accepted. Match the alpha as `0`, `0.<digits>`, `1` or `1.<zeros>` instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
The alpha channel in the
rgbaandhslaregexes is(?:0.[1-9]*)|[01]. The.is not escaped, so it matches any character, and[1-9]*does not allow a zero anywhere in the fraction. As a result, valid CSS colours fail and malformed ones pass:rgba(0,0,0,0.05)rgba(0,0,0,0.50)rgba(0,0,0,0.0)rgba(0,0,0,1.0)hsla(0,0%,0%,0.05)rgba(0,0,0,0a)hsla(0,0%,0%,0x)A semi-transparent shadow such as
rgba(0,0,0,0.05)is a very common value, and it currently failsrgbaandiscolorvalidation.The fix changes the alpha part in both regexes to
0(?:\.\d+)?|1(?:\.0+)?. That accepts0,1,0.<digits>and1.<zeros>, and still rejects values above 1. Nothing else in the regexes changes.TestRgbaHslaAlphaValuecovers valid and invalid alpha values forrgba(numeric and percent forms) andhsla. On the current master it fails withrgba: "rgba(0,31,255,0.05)" should be valid. With this change it passes, and so doesgo test ./....This PR was AI-assisted: the bug was found, and the fix and test were written, with Claude Opus 5.5. I checked the failing and passing test runs above.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers