Repository navigation
Add native text selection and keyboard shortcuts - #81
Merged
Merged
Conversation
iamnbutler
marked this pull request as ready for review
October 5, 2026 12:03
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
desktop_selectfor literal text selection and caret placement, with adjacent prefix/suffix matching for repeated text. Extendsdesktop_keywith navigation, letters, digits, function keys, and Command/Control/Option/Shift shortcuts while preserving exact observed targets, complete press/release chords, and unsafe-to-replay mutations. Editable controls with an absent AXEnabled flag are accepted; explicitly disabled controls remain refused.Refs #65 and #8. Closes #66. This extracts the selection and shortcut work from #67 onto merged #63. Literal insertion remains separate work in #65 / #76; this PR adds no insertion or clipboard tool.
Validation: fresh
bun types,bun run ci,git diff --check, Ace diff review, and independent source review pass. The unchanged selection/shortcut paths previously passed real signed AppKit checks atd04c8c4: contextual UTF-16 selection/caret positioning, ambiguous and disabled refusal, Command+A, Shift+Right, backward/forward delete, and consumed-snapshot refusal. The existing real local pi and hosted-workspace runs also exercised these paths and replayed persisted results/screenshots after restart without repeated input. Those earlier combined-workflow results are reused only for selection and shortcuts; they do not certify the separate literal-insertion implementation. This extracted branch has not yet been rebuilt or launched as a signed app.Built in Ace
Dependency installation, checks, Git commits/pushes, and PR creation run through an Ace terminal. The six-file diff was reviewed through Ace's changes/patch APIs. Codex performed source inspection/editing and independent review because native Codex integration (#9) and an Ace file editor (#22) remain open. No new native desktop actions or model runs were performed for this extraction.