Repository navigation
Read bounded clipboard image previews - #135
Merged
Merged
Conversation
…rd-image # Conflicts: # apps/desktop/native/sources/desktop/desktop.swift # docs/desktop-tools.md
This was referenced Oct 5, 2026
…rd-image # Conflicts: # apps/desktop/scripts/helper.ts
iamnbutler
marked this pull request as ready for review
October 5, 2026 22:42
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
desktop_clipboard_readwith optionalformat: "image"for #72 and #8. The default plain-text path keeps its existing result and limits. Image reads return one generation-consistent PNG/JPEG/TIFF representation as an oriented preview, with separate source and preview metadata.The GUI checks silent clipboard permission, one complete frame, a 10 MiB source limit, and 64 million pixels. Rendering runs off the GUI actor and preserves transparency with PNG when possible, using an explicitly white-composited JPEG only when needed to fit the 1,600-pixel/900 KB preview limits. The existing tool image result carries the preview directly. Reads neither change the clipboard nor release a pending paste reservation. A format parameter on clipboard-write is refused.
Validation at
c6bd49d42a20cac963eb3c87272a12fb921ab46f:gpt-6-solchannel used one image-read tool call. After its worker closed and reopened, exact text/image results, provider usage, tool logs, and clipboard generation were unchanged. The owned channel/project was then removed.Local evidence:
/tmp/ace-clipboard-image-check.PZS6Xk/result.json,/tmp/ace-clipboard-image-check.aB0564/result.json, and the correspondingexact-cleanup.jsonfiles under/tmp/ace-clipboard-image-live.jkbmSvand/tmp/ace-clipboard-image-live.ZUlS1O. Image writes, files, and temporary paste remain separate slices of #72.Built in Ace
Codex used external source, Git, build, and temporary-helper tools under the user's explicit temporary exception while #8 is implemented. Ace cannot yet host this Codex harness (#9) and has no File tab for direct source editing (#22). Runtime checks used Ace's actual signed GUI bridge, host adapter, channel worker, tool result/history path, and real provider credentials; the temporary vault preserved the clipboard privately.