Repository navigation
feat(desktop): minimize exact native windows - #133
Merged
Merged
Conversation
iamnbutler
marked this pull request as ready for review
October 5, 2026 22:15
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents can minimize one native window with
desktop_minimize, using its unchanged target fromdesktop_windows. The existing signed native path binds the action to the observed process generation, window ID, bounds, and minimized state; it confirms a change or an already-minimized no-op and preserves uncertain delivery without retrying.Successful minimize returns fresh window inventory without attempting to capture the minimized window. Restoring it is a separate explicit
desktop_restoreaction with the refreshed target.Related to #8 and #73.
Validation at
1d0f328:bun types,bun run ci,git diff --check, Swift syntax checks, the signed desktop build, and deep/strict signature verification pass. GitHub CI is green.desktop_minimizeonce. A different worker reopened the same store with identical result/usage and no new model/tool execution or minimize callback. Explicit restore succeeded again. All owned fixture, app, host, and worker processes exited; the temporary channel/project, listener, and native socket were removed.The live cancellation check covers pre-dispatch cancellation, not an in-flight cancellation claim.
Built in Ace
Used Codex's terminal and file tools for implementation, source review, and validation under Nate's explicit temporary exception to Ace-only development while completing computer use in #8. Live validation used Ace's actual native bridge and pi channel worker with a real provider; no mocked providers or alternate input path. The ongoing dogfooding gap is tracked in #5 and #8.