Repository navigation
feat(desktop): add exact-target normal application quit - #132
Merged
Merged
Conversation
This was referenced Oct 5, 2026
# Conflicts: # apps/desktop/scripts/helper.ts
iamnbutler
marked this pull request as ready for review
October 5, 2026 21:50
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
desktop_quitfor one exact running application fromdesktop_apps. The native bridge requests normal quit with the observed PID and process generation and never force-quits or retries. Confirmed termination returnscompleted; an accepted request that leaves the application running returnsunknownand refreshed application/window inventory, so the agent can inspect unsaved-work dialogs deliberately. Later inventory cannot change the recorded quit outcome.A focused patch to pinned Peekaboo preserves accepted but unfinished normal quit as one dispatched operation with unsafe retry. Its quit-specific result validator permits this uncertain outcome with
falsetermination, allowing the existing bridge to retain the signed process receipt instead of rejecting the result. Other contradictory outcomes and force-quit behavior stay unchanged.Part of #8.
Validated on
086c9c4, including current main's #120 and #131:bun types,bun run ci,git diff --check, signedbun desktop build dev, and strict signature verification passed. Independent source and validation-driver reviews found no blocker.unknown,terminated: false, unsafe retry, and the exact receipt with fresh windows.gpt-6-solchannel useddesktop_quitonce to terminate the normal fixture. The completed result retainedterminated: truewhen later inventory returned no application.Built in Ace
Used Codex for source editing, terminal work, independent review, and validation orchestration under Nate's explicit temporary exception to the Ace-only workflow. Ace did not yet expose the native quit capability being implemented, and this exception allows work on the computer-use gaps in #8 and #5. The real model check ran through Ace's actual source host, channel worker, signed desktop bridge, and durable store. Desktop checks used a coordinated slot and disposable public fixtures.