Skip to content

Issue 7674 - Update Docker image test scripts - #8146

Closed
sylvesterkaczmarek wants to merge 2 commits into
gchq:developfrom
sylvesterkaczmarek:issue-7674-docker-image-tests
Closed

sylvesterkaczmarek wants to merge 2 commits into
gchq:developfrom
sylvesterkaczmarek:issue-7674-docker-image-tests

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Issue

Tests

  • This corrects which existing Docker image system test the local compaction script selects, so no new Java test is needed.
    • bash -n scripts/test/docker/testCompactionDockerImage.sh
    • bash -n scripts/test/docker/buildTestCompactionDockerImage.sh
    • mvn -pl clients -am -DskipTests -Drust.skip=true test-compile completed successfully, including compilation of CompactionTaskDockerImageST
    • shellcheck passed for both Docker test scripts
    • git diff --check passed
    • The Docker-backed system test was not run locally because the Docker daemon is unavailable on this machine

Documentation

  • Updated docs/development/dev-scripts.md to state the required project build and point to buildTestCompactionDockerImage.sh for the complete compaction-image workflow.
  • No Java code was added, so no Javadoc change is required.
  • No dependencies were added or removed, so NOTICES is unchanged.

@sylvesterkaczmarek
sylvesterkaczmarek force-pushed the issue-7674-docker-image-tests branch from 50fe695 to e3eaa21 Compare September 24, 2026 07:07
@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor Author

Rebased cleanly onto current develop as one SSH-verified commit (e3eaa21c7c). The branch is 0 behind and mergeable. bash -n and ShellCheck pass for the changed Docker test script, and the clients dependency reactor test-compiles successfully under JDK 17. Ready for review.

@sylvesterkaczmarek
sylvesterkaczmarek force-pushed the issue-7674-docker-image-tests branch from e3eaa21 to 00545a2 Compare September 30, 2026 14:46
@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor Author

Hi maintainers, following up on this PR as it hasn’t had a maintainer review yet. There are no merge conflicts and the validation is documented above. Could someone take a look when convenient? Happy to address any feedback.

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor Author

Following up on the Docker test script correction. Could someone take a look?

@gaffer01

Copy link
Copy Markdown
Member

We thank you for your contribution. However, please see the updated contributing guidance here https://github.com/gchq/sleeper/blob/develop/CONTRIBUTING.md

@gaffer01 gaffer01 closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update scripts to run Docker image tests

2 participants