Repository navigation
docs: add typecheck target to AGENTS.md local affected command - #135
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local pre-push command in AGENTS.md listed "pnpm nx affected -t lint test build", but CI (since the typecheck target was added via @nx/js/typescript plugin and "chore(ci): do typecheck on ci") now runs "pnpm exec nx affected -t lint typecheck test build". The doc command was missing the new "typecheck" target, so a contributor copying it would push a PR that fails the very CI check the doc is meant to mirror and have no local signal as to why.
Introduced by commit 8578893 (@fwal, #133)
Doc Drift PRs can be configured here.