Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1679.
SFTP
info()always follows symlinks, so it cannot return the link metadata shown by a detailed directory listing or inspect a dangling link. Addfollow_symlinks=Falseto use Paramiko'slstat(). The default remainsTrue, preserving existing behavior.Regression tests cover links to files, directories and missing targets, with bare paths and both SFTP/SSH URL schemes. They compare link metadata with
ls(detail=True)and check that regular paths and the default behavior are unchanged. The option is included in the API documentation and changelog.Validation on Python 3.12:
pre-commit run --all-files: passed.sphinx-build -b html -W --keep-going docs/source ../fsspec-docs: passed.The existing 17 Docker-based SFTP tests were skipped because Docker is unavailable locally. Other skips cover optional backends and platform-specific cases. Windows and the full optional-backend suite were not run locally.