You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 17, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 17, 2021. It is now read-only.
it looks like toolbox is not compatible with node 6 (use of trailing comma in function args list, use of async, etc).
It would be nice to see if we can be compatible with the maximum version of node and at least define with which version of nodejs this project is compatible.
Indeed, I saw that the last major version of our generator doesn't have the engine specified in the package.json.
I don't completely agree with the fact that we have to support a big range of Node's versions. Actually, the LTS (stable for prod) is in 8.10.0 and as you said, under 8.0.0, there is no async support, it's a bit the Middle Ages of JavaScript and we must live in the present 😉
We have to readd the engine definition in the package.json project with something like :
Activity
Yago commentedon Mar 23, 2018
Indeed, I saw that the last major version of our generator doesn't have the engine specified in the package.json.
I don't completely agree with the fact that we have to support a big range of Node's versions. Actually, the LTS (stable for prod) is in
8.10.0and as you said, under8.0.0, there is noasyncsupport, it's a bit the Middle Ages of JavaScript and we must live in the present 😉We have to readd the engine definition in the
package.jsonproject with something like :gido commentedon Mar 25, 2018
+1 for defining the requirement in the package.json
6.xis still Active until the end of April 2018 and will be maintained until April 2019. So it's not really the Middle Ages of Javascript ;-)(source)
I agree we must live in the present but think also of the past and don't drop to easily active/maintained version of nodejs without a good reason.
tonifisler commentedon May 21, 2019
This needs to be fixed, it's quite annoying. As @knuch said in #36, if you don't work with Node 12, it's broken. SMH
Yago commentedon May 21, 2019
The weird fact is that I still haven't Node 12 installed on my Mac (even on the last contrib) 😅
Yago commentedon May 21, 2019
“it's broken” is not very relevant... What's broken exactly ?