Skip to content
This repository was archived by the owner on Jun 17, 2021. It is now read-only.
This repository was archived by the owner on Jun 17, 2021. It is now read-only.

Specify the requirements #28

Open
Open

Description

@gido

it looks like toolbox is not compatible with node 6 (use of trailing comma in function args list, use of async, etc).

It would be nice to see if we can be compatible with the maximum version of node and at least define with which version of nodejs this project is compatible.

Activity

  1. Yago commented on Mar 23, 2018

    @Yago
    Member

    Indeed, I saw that the last major version of our generator doesn't have the engine specified in the package.json.

    I don't completely agree with the fact that we have to support a big range of Node's versions. Actually, the LTS (stable for prod) is in 8.10.0 and as you said, under 8.0.0, there is no async support, it's a bit the Middle Ages of JavaScript and we must live in the present 😉

    We have to readd the engine definition in the package.json project with something like :

    "engines": {
      "node": ">=8.0.0",
      "npm": ">=5.0.0"
    },
  2. gido commented on Mar 25, 2018

    @gido
    Author

    +1 for defining the requirement in the package.json

    6.x is still Active until the end of April 2018 and will be maintained until April 2019. So it's not really the Middle Ages of Javascript ;-)

    schedule
    (source)

    I agree we must live in the present but think also of the past and don't drop to easily active/maintained version of nodejs without a good reason.

  3. tonifisler commented on May 21, 2019

    @tonifisler
    Member

    This needs to be fixed, it's quite annoying. As @knuch said in #36, if you don't work with Node 12, it's broken. SMH

  4. Yago commented on May 21, 2019

    @Yago
    Member

    The weird fact is that I still haven't Node 12 installed on my Mac (even on the last contrib) 😅

  5. Yago commented on May 21, 2019

    @Yago
    Member

    “it's broken” is not very relevant... What's broken exactly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions