Repository navigation
Conversation
Expose Fluent Bit's Time_Strict setting on the json, logfmt, ltsv and regex parsers so users can turn off strict time parsing, e.g. when a timestamp has no fractional seconds but the format expects them. Fixes fluent#1433 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
cvas22
marked this pull request as ready for review
October 22, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an optional
timeStrictfield to thejson,logfmt,ltsvandregexparsers (ClusterParser and Parser). It is rendered as Fluent Bit'sTime_Strictparser option, so strict time parsing can be turned off. Without it, a log line whose timestamp does not exactly matchTime_Format(for example no fractional seconds) is rejected withinvalid time format.When the field is not set nothing is rendered, so existing configs are unchanged.
Changes: the four parser types and their generated deepcopy, the CRDs (config, both charts,
manifests/setup/setup.yaml), the parser reference docs, and a unit test for the rendered output.Which issue(s) this PR fixes:
Fixes #1433
Special notes for your reviewer:
I updated the CRD yaml and deepcopy by hand to match what the generators produce, and did not run
make manifestslocally. Please check that CI shows no generated-file drift.Unrelated, not changed here: in
lstv_types.gotheTimeKeepvalue is rendered underTime_Formatinstead ofTime_Keep.Tested with
go test ./apis/fluentbit/v1alpha2/plugins/parser/.