Repository navigation
Keep keyless mode with a trailing slash in the cloud API URL - #275
Open
danielgaskins wants to merge 3 commits into
Open
danielgaskins wants to merge 3 commits into
danielgaskins wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 6 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Normalizes trailing slashes on API base URLs so the cloud URL with a trailing slash keeps keyless/API-key behavior. Focused bug fix with regression tests covering URL classification, keyless request joining, and validation.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trailing slashes on the default Firecrawl cloud URL now keep the same keyless and authentication behavior as the URL without a slash. Custom API URLs remain custom.
Updated this branch against current main, keeping its CLI headers and API-issued signup links. Regression tests cover URL classification, keyless GET/POST paths, and API-key validation.
Validation: 689 tests pass. Build, type checking, formatting, and whitespace checks pass. Five regression cases fail against current main and pass here.
Fixes #274