Repository navigation
chore(deps): bump golang.org/x/mod from 0.24.0 to 0.42.0 in /generators/go - #18329
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.24.0 to 0.42.0. - [Commits](golang/mod@v0.24.0...v0.42.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.42.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
AI Review Summary
Dependabot bump of golang.org/x/mod (0.24.0 → 0.42.0) and golang.org/x/tools (0.32.0 → 0.51.0) in generators/go. The notable side effect is the go directive jumping from 1.23.0 to 1.26.0, which raises the minimum toolchain required to build this generator.
- 🟡 1 warning(s)
Review Scope
- Mode: Full pull request
- Range:
Full pull request through 93becc40dd930102b326e0cf7a870ea93c812665 - Current range coverage: Complete
- Cumulative pull request coverage: Complete
This review is complete for the current scope. Addressing all critical and warning findings above satisfies the review; suggestions are optional. Request another review only if subsequent changes introduce new behavior or materially expand the pull request's scope.
| module github.com/fern-api/fern-go | ||
|
|
||
| go 1.23.0 | ||
| go 1.26.0 |
There was a problem hiding this comment.
🟡 warning
This bump drags the go directive from 1.23.0 to 1.26.0 (x/mod v0.42.0 requires it). That makes Go 1.26 the hard minimum for anyone building or go install-ing this generator — CI images, Dockerfiles, and downstream consumers pinned to an older toolchain will fail with go.mod requires go >= 1.26.0. Worth confirming the generator's build images are on 1.26 before merging; otherwise consider pinning x/mod to the last release compatible with 1.23.
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
SDK Generation Benchmark ResultsComparing PR branch against median of 5 nightly run(s) on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
Bumps golang.org/x/mod from 0.24.0 to 0.42.0.
Commits
b5136e5sumdb/tlog: use recorded responses in TestCertificateTransparency1e9a5aego.mod: update golang.org/x dependenciesd0a27b2modfile: fix Cleanup and DropTool documentationd12008call: upgrade go directive to at least 1.26.0 [generated]d3398d0go.mod: update golang.org/x dependencies57549bfsumdb: ignore unrelated hashes in Lookup96f62aesumdb/tlog: fix TileHashReader authentication bypass13be902go.mod: update golang.org/x dependencies792ac16go.mod: update golang.org/x dependenciesfe2ec04all: fix some comments to improve readabilityDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)