Skip to content

Move compiler-specific macros to their own section - #5777

Open
JAicewizard wants to merge 2 commits into
facebookresearch:mainfrom
JAicewizard:mingw
Open

JAicewizard wants to merge 2 commits into
facebookresearch:mainfrom
JAicewizard:mingw

Conversation

@JAicewizard

Copy link
Copy Markdown
Contributor

Fixes #5775

This moves the msvc, swig and gcc/clang flags to their own section, so that they don't get confused with target specific flags

@meta-cla meta-cla Bot added the CLA Signed label Oct 24, 2026
@JAicewizard

Copy link
Copy Markdown
Contributor Author

The logs provide no useful information on what went wrong, anyways to get the actual error messages?

@mnorris11

Copy link
Copy Markdown
Contributor

looks like swig parsing stopped at line 33:

2026-10-24T14:18:23.1604142Z C:\a\faiss\faiss\faiss\python\..\..\faiss\impl\RaBitQUtils.h(33): error : Syntax error in input(1). [C:\Users\runneradmin\AppData\Local\Temp\tmpmyo3ynfk\build\faiss\python\swigfaiss.vcxproj]

@JAicewizard

Copy link
Copy Markdown
Contributor Author

Ah thank you!! Looks like it was hidden under the green checkmarked build step.
The issue is probably a workaround defined in swigfaiss.swig, added a workaround for it. If it doesnt pass I will look into it tomorrow

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MinGW build faillure

2 participants