Repository navigation
Add support for 'mantaray' manifest, and make it default - #621
Merged
Merged
Conversation
pradovic
approved these changes
Aug 27, 2020
acud
reviewed
Aug 27, 2020
| } | ||
| } | ||
|
|
||
| func (ls *mantarayLoadSaver) Load(ref []byte) ([]byte, error) { |
Contributor
There was a problem hiding this comment.
i don't really understand why this stuff is necessary. while refactoring the splitter i noticed that the dependencies to the joiner and splitter have crept into this package and i don't really understand why. this seems like an unnecessary abstraction over simple generic interfaces like BinaryMarshaler/Unmarshaler. also i don't really understand the semantics here, from Load of a mantarayLoader I would expect to return a mantaray type, not a byte slice. this is just an abstraction over splitter and joiner. why?
zbiljic
force-pushed
the
feature/mantray-manifest
branch
from
August 27, 2020 16:13
3eb8fc7 to
b94a63a
Compare
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds
mantaraymanifest implementation forbee.Externally from
pkg/manifestpackage there are no changes, expect to some test, where some edits were required.Since the
mantarayimplementation containsobfuscationKey, which is generated randomly for new manifest, each time collection is uploaded, new hash will be returned by the service.