Skip to content

New: Configuring core options in Config Files - #22

Merged
mysticatea merged 18 commits into
masterfrom
2019-linter-options
Aug 6, 2019
Merged

mysticatea merged 18 commits into
masterfrom
2019-linter-options

Conversation

@mysticatea

@mysticatea mysticatea commented May 12, 2019 •

Copy link
Copy Markdown
Member

Rendered RFC

Summary

This RFC adds several properties into config files to configure core options. People can use config files (including shareable configs!) instead of CLI options in order to configure some linter behavior.

Related Issues

@mysticatea mysticatea added feature Initial Commenting This RFC is in the initial feedback stage labels May 12, 2019

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this RFC! I left a few thoughts.

Comment thread designs/2019-linter-options/README.md Outdated
Comment thread designs/2019-linter-options/README.md Outdated
Comment thread designs/2019-linter-options/README.md Outdated
Comment thread designs/2019-linter-options/README.md Outdated
Comment thread designs/2019-linter-options/README.md Outdated
@mysticatea mysticatea changed the title New: The linterOptions property in Config Files New: The coreOptions property in Config Files May 12, 2019
@mysticatea

ghost commented May 23, 2019

Copy link
Copy Markdown
Member Author

@not-an-aardvark Thank you for your feedback. I updated this RFC. I think it has addressed your concerns.

@aladdin-add

ghost commented Jun 7, 2019 •

Copy link
Copy Markdown
Member

image

the rendered link seems broken.

@mysticatea

ghost commented Jun 7, 2019

Copy link
Copy Markdown
Member Author

Oh, thank you. I have fixed the link.

@mysticatea mysticatea changed the title New: The coreOptions property in Config Files New: Configuring core options in Config Files Jun 17, 2019
@mysticatea

ghost commented Jun 17, 2019

Copy link
Copy Markdown
Member Author

I have updated this RFC for some feedback.

  • Move coreOptions.* properties to top-level.
  • Disallow ignorePatterns in overrides entries to avoid confusion with excludedFiles property.

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns from me at this point.

@mysticatea

ghost commented Jun 27, 2019

Copy link
Copy Markdown
Member Author

@kaicataldo @not-an-aardvark Does the latest update solve your concerns? If so, I will move this RFC to the final commenting.

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about renaming property names, but otherwise this LGTM. Thanks for working on this!

Comment thread designs/2019-core-options/README.md Outdated
Comment thread designs/2019-core-options/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Final Commenting This RFC is in the final week of commenting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants