Dependencies are not packaged by electron-builder when using pnpm

Electron-Builder Version: 22.11.7

Node Version: 16.9.1

Electron Version: 15.0.0
Electron Type (current, beta, nightly): current

Target: windows/nsis

I'm having issues trying to use pnpm and electron-builder. I tried multiple times to package the app using basic commands and build configurations from online guides but i would always get dependency related errors after packaging it.

Initially i thought it was my configuration error, but after copying the whole project and used npm instead, everything worked as expected.

From what i could find, it seems that electron-builder can't resolve the dependencies within the .pnpm folder, but i am not 100% certain of this.

pnpm and electron-builder are both great would love to have this fixed

Build config

Using pnpm

As shown in the screenshot, semver already exist in node_modules/.pnpm

Using npm with same exact build config

Application is built with no errors by electron-builder

@develar

@develar can you please take a look at this when you have a chance?

Run into same problem, the node_modules folder bundled in app.asar does not contain modules installed under .pnpm/, which are symlinks created by pnpm install.

Any updates?

Hey guys!
Do you have any plans to support pnpm?
It reduces pain for developers that have gigabytes of node_modules placed here and there.
Would love to use it with electron too.

I don't have plans to implement the support for pnp. But I'd happily review PRs for it! 🙂

Same here, would be awesome to have support for it

Quick test, can someone try setting .npmrc to copy from the global pnpm store for deps?
https://pnpm.io/npmrc#package-import-method

package-import-method=copy

I tried the copy setting. But doesn't seem to make any difference for me.

@develar

@develar really could use your help on this one. Seems to be failing with readDependencyTree in your app-builder project.
https://github.com/develar/app-builder/blob/c79345743b794ccef41493decafb0b5b2eece505/pkg/node-modules/tree.go#L41

I've tried other alternatives for reading dependency trees and they aren't viable. I'm not sure how app-builder works, but it seems like it just needs to also search node_modules/.pnpm/node_modules/* for all dependencies

set node-linker=hoisted in .npmrc
set public-hoist-pattern = * or shamefully-hoist = true in .npmrc

Choose any of them. The problem will be solved.
Of course, it would be great if electron-builder could support it.

Update:

If your dependencies have multiple versions, it's best to add node-linker = hoisted to avoid having only one version selected during packaging. Refer to the link for more information: pnpm/pnpm#5724 (comment)

Same. Would really love to see it is supported.

@BlackHole1

@BlackHole1 thanks for the suggested solution. This is probably an acceptable solution for some however the suggested approach is basically throwing away the benefits of using pnpm in the first place.

The repo's readme also links to a comment about why yarn should be used however with 129 downvotes and 94 confused emojis it's clearly not backed by the community running into these issues.

I'm not able to provide a better solution myself but I'd like to point out how much of a hurdle this is for adoption. We're not prepared to relax the reliability of our dependency system that pnpm brings to our monorepo. Changing this for a single package is an unreasonable ask. I hope there is a path forward soon; A fundamental library shouldn't have to compromise it's audience based on a package manager.

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Any progress here?

Issue is in upstream dependency app-builder (node_modules/app-builder-bin)
Ref: #6289 (comment)
You're welcome to file a ticket here https://github.com/develar/app-builder

Workaround is: #6289 (comment)

Navigation Menu

Repository navigation

Dependencies are not packaged by electron-builder when using pnpm #6289

Build config

Using pnpm

Using npm with same exact build config

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Dependencies are not packaged by electron-builder when using pnpm #6289

Description

Build config

Using pnpm

Using npm with same exact build config

Activity

mmaietta commented on Sep 26, 2021

cangzhang commented on Sep 28, 2021

plimeor commented on Oct 11, 2021

cah4a commented on Nov 19, 2021

mmaietta commented on Nov 21, 2021

cupcakearmy commented on Jan 21, 2022

mmaietta commented on Feb 5, 2022

monsterkodi commented on Feb 6, 2022

mmaietta commented on Feb 9, 2022

BlackHole1 commented on Feb 17, 2022

CallanBi commented on Feb 24, 2022

the0rem commented on Feb 24, 2022

stale commented on Apr 28, 2022

cah4a commented on Apr 28, 2022

mmaietta commented on Apr 28, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions