[100pah]

1. Fix some issues introduced by PR feat(canvas): update DPR after resizing #1149:

• Fix the incorrect… usage of this in callback function (

  zrender/src/canvas/Painter.ts

  Line 1254 in 3491110

  layer.resize(width as number, height as number, this.dpr);

  ). And the corresponding TS error.
• PathProxy#setScale was called before PathProxy#setDPR, but PathProxy#setScale used DPR. Fix that: remove setDPR method and add DPR as a parameter of setScale.

2. Fix and clarify width/height parameters processing in constructor and resize method in singleCanvas case - align them with non-singleCanvas case.
3. Remove attaching dpr to CanvasRenderingContext2D - not necessary and error-prone.
4. Fix SVG renderer Painter#toDataURL and Painter#renderToString - add the missing escaping on attribute values.

[Copilot]

🟡 Changes recommended

Unresolved canvas resizing and export-scaling regressions can produce incorrectly sized or clipped output.

4 open findings

• Limit dimension guard to style-less canvas roots · New
• Preserve logical dimensions during DPR-only resize · New
• Resize all managed layers in single-canvas mode · New
• Use export layer DPR for high-resolution rendering · New

What changed in this PR

Addresses rendering issues introduced by #1158 by making device pixel ratio (DPR) explicit and revising canvas sizing.

Changes:

• Passes DPR through brush scopes and path scaling instead of attaching it to rendering contexts.
• Refactors single-canvas sizing and fixes the resize callback’s this usage.
• Consolidates shared sizing and rendering option types.

File	Description
src/​zrender.ts	Uses shared options and clarifies resize documentation.
src/​PainterBase.ts	Reuses shared resize parameter types.
src/​graphic/​Displayable.ts	Adds DPR to brush parameters.
src/​graphic/​CompoundPath.ts	Passes DPR to child path scaling.
src/​core/​types.ts	Defines shared options and dimension constants.
src/​core/​PathProxy.ts	Accepts DPR directly in setScale.
src/​core/​BoundingRect.ts	Reuses shared dimension constants.
src/​canvas/​Painter.ts	Revises sizing, resizing, and DPR propagation.
src/​canvas/​Layer.ts	Removes context DPR markers and centralizes bitmap sizing.
src/​canvas/​helper.ts	Adds single-canvas size resolution.
src/​canvas/​graphic.ts	Uses brush-scope DPR throughout rendering.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.