Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decomposeTransform()normalizes the matrix for an element's existing origin before callingsetLocalTransform(). That call resets the origin to zero, so the next update reconstructs the matrix around the wrong point and a dragged element jumps.Restore the saved origin after decomposition. Direct
setLocalTransform()calls keep their existing origin-zero behavior.Nonzero anchors retain their separate existing translation issue during decomposition; this change addresses the origin reset only.
Validation on Node 18.20.8:
setLocalTransform()contract.npm run lintpassed.npm run releaseremains blocked by the pre-existing TS2683 atsrc/canvas/Painter.ts:1254(this.dprinside a callback). Painter, the TypeScript configuration and dependencies are unchanged; no build diagnostics were disabled.The Windows Jest command uses the same test glob with forward slashes to avoid Jest 27's path-normalization issue with the
.agent-storageparent. The test scope and TypeScript diagnostics are unchanged.Fixes #1172.