Skip to content

Rename release profile - #133

Merged
cstamas merged 6 commits into
mainfrom
release-profile
May 30, 2024
Merged

cstamas merged 6 commits into
mainfrom
release-profile

Conversation

@cstamas

@cstamas cstamas commented May 30, 2024

Copy link
Copy Markdown
Member

As we dumped nx2 staging plugin, rename the profile ID to something more logical: "sisu-release".

As we dumped nx2 staging plugin, rename the profile
ID to something more logical: "sisu-release".
@cstamas
cstamas requested review from kwin and mcculls May 30, 2024 10:23
@cstamas cstamas self-assigned this May 30, 2024
<profiles>
<profile>
<id>sonatype-oss-release</id>
<id>sisu-release</id>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the default profile name release?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it may conflict with out of the box profile, and as you see, release plugin explicitly disables it.

@cstamas cstamas May 30, 2024 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the release profile used by project was not "default" anyway, this PR does not change in this respect, just shortens its name (and aligns it, with other "release profiles" like apache-release or takari-release etc).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't get why we need a project-specific prefix. I like to have the same profile name across all projects, therefore I usually pick release. But as it always has been used with some prefix I am fine with keeping it.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cstamas cstamas added this to the 0.9.0.M3 milestone May 30, 2024
@cstamas
cstamas merged commit 1305b17 into main May 30, 2024
@cstamas
cstamas deleted the release-profile branch May 30, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants