Skip to content

Overflow when scrollback > terminal rows #5

Closed

Description

@chris-laplante

vt100 is misbehaving if you set scrollback > terminal rows. Please see #4. If you run cargo test scrollback, you'll get this:

running 2 tests
test scrollback_larger_than_terminal ... FAILED
test scrollback ... ok

failures:

---- scrollback_larger_than_terminal stdout ----
thread 'scrollback_larger_than_terminal' panicked at 'attempt to subtract with overflow', src/grid.rs:125:42
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Activity

  1. jeevithakannan2 commented on Oct 2, 2024

    @jeevithakannan2

    Is there a work around for this issue ?

  2. chris-laplante commented on Oct 2, 2024

    @chris-laplante
    Author

    Is there a work around for this issue ?

    I'll double-check, but I don't think I ever found one :(

  3. jeevithakannan2 commented on Oct 2, 2024

    @jeevithakannan2

    Okay, thank you !!

  4. chris-laplante commented on Oct 2, 2024

    @chris-laplante
    Author

    Okay, thank you !!

    Unfortunately I don't think I ever implemented any workarounds for this. I would have encountered it in indicatif, possibly with this issue: console-rs/indicatif#474

  5. doy commented on Jan 11, 2025

    @doy
    Owner

    fixed in 3e591c3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions