Repository navigation
Handle direct navigation to the authentication login callback - #69721
Open
vendasankarsf3945 wants to merge 6 commits into
Open
vendasankarsf3945 wants to merge 6 commits into
vendasankarsf3945 wants to merge 6 commits into
Conversation
Contributor
|
Thanks for your PR, @vendasankarsf3945. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
…into fix/54586-login-callback-navigation # Conflicts: # src/Components/test/testassets/Components.TestServer/Components.TestServer.csproj
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved build dependencies, custom-provider compatibility, and test isolation issues block approval.
4 open issues
What changed in this PR
This PR addresses #54586 by restarting login when users navigate directly to a Blazor WebAssembly authentication callback, while preserving iframe callback behavior.
Changes:
- Adds top-level window checks to both authentication providers.
- Updates callback handling and unit tests.
- Adds browser coverage and an MSAL test application.
| File | Description |
|---|---|
| src/Components/WebAssembly/WebAssembly.Authentication/test/RemoteAuthenticatorCoreTests.cs | Tests top-level and iframe callbacks. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs | Restarts login for top-level callbacks. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/Interop/AuthenticationService.ts | Adds OIDC window-context check. |
| src/Components/WebAssembly/Authentication.Msal/src/Interop/AuthenticationService.ts | Adds MSAL window-context check. |
| src/Components/test/testassets/Components.WasmRemoteAuthentication/Pages/TestRemoteAuthentication.razor | Adds root landing route. |
| src/Components/test/testassets/Components.WasmRemoteAuthentication/Pages/SilentAuthentication.razor | Adds silent-authentication observation page. |
| src/Components/test/testassets/Components.WasmMsalRemoteAuthentication/Routes.razor | Configures MSAL test routing. |
| src/Components/test/testassets/Components.WasmMsalRemoteAuthentication/RedirectToLogin.razor | Initiates MSAL login. |
| src/Components/test/testassets/Components.WasmMsalRemoteAuthentication/Program.cs | Configures MSAL authentication paths. |
| src/Components/test/testassets/Components.WasmMsalRemoteAuthentication/Pages/TestRemoteAuthentication.razor | Displays authentication outcome. |
| src/Components/test/testassets/Components.WasmMsalRemoteAuthentication/Pages/Authentication.razor | Hosts authentication actions. |
| src/Components/test/testassets/Components.WasmMsalRemoteAuthentication/Components.WasmMsalRemoteAuthentication.csproj | Defines MSAL test application. |
| src/Components/test/testassets/Components.TestServer/RemoteMsalAuthenticationStartup.cs | Hosts MSAL test endpoints. |
| src/Components/test/testassets/Components.TestServer/RemoteAuthenticationStartup.cs | Adds callback controls and observations. |
| src/Components/test/testassets/Components.TestServer/RazorComponents/RemoteMsalAuthenticationApp.razor | Hosts and instruments MSAL app. |
| src/Components/test/testassets/Components.TestServer/RazorComponents/RemoteAuthenticationApp.razor | Observes iframe callback handling. |
| src/Components/test/testassets/Components.TestServer/Components.TestServer.csproj | References MSAL test dependencies. |
| src/Components/test/E2ETest/Tests/RemoteMsalAuthenticationTest.cs | Tests direct MSAL callback navigation. |
| src/Components/test/E2ETest/Tests/RemoteAuthenticationTest.cs | Tests direct navigation and iframe behavior. |
Review effort: Balanced
Contributor
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle explicit login-callback navigation in Blazor WASM
Description
Explicit navigation to
/authentication/login-callbackin Blazor WebAssembly can leave the app stuck in theCompletingLoggingInsegment ofRemoteAuthenticatorView, even though no login flow is active. This makes the app appear broken when users land directly on the callback route.Root cause
Users could explicitly navigate to the
/authentication/login-callbackroute in a Blazor WebAssembly app. In those cases, the app treated the navigation like a normal authentication callback and left the user in theCompletingLoggingInsegment ofRemoteAuthenticatorView, even though no login flow was actively in progress. This caused the app to appear stuck and the user experience to degrade.Changes
/authentication/login-callbackBefore
A user directly navigates to
/authentication/login-callback:CompletingLoggingInsegmentAfter
A user directly navigates to
/authentication/login-callback:Fixes #54586