Repository navigation
Don't fail isolated tests when job object assignment fails - #1121
Merged
Merged
Conversation
`MultiplexingStreamPerfTests` (net472 only) intermittently fail in CI with `Win32Exception : The parameter is incorrect` thrown from `ProcessJobTracker.AddProcess`. Assigning the isolated test host process to a job object is only a best-effort safety net that kills orphaned child processes if this process dies unexpectedly. It can fail for environmental reasons outside our control (e.g. the process already belongs to a job hierarchy that our job is not part of, as can happen under the CI agent), so its failure must not fail the test. Also capture the Win32 error code immediately after the failed P/Invoke. The previous code called `Process.HasExited` first, which issues its own interop calls and clobbers the last error, so the reported error code was unreliable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 26, 2026
This repo's nuget.config only references nuget.org, so the Azure Artifacts
credential provider is never needed. Installing it queries the GitHub
releases API anonymously, which intermittently fails the build before
anything is compiled:
installcredprovider.ps1: Unable to resolve the browser download url from
https://github.com/proxy/api.github.com/repos/Microsoft/artifacts-credprovider/releases/latest
Error: Response status code does not indicate success: 403 (rate limit exceeded).
copilot-setup-steps.yml already passed -NoNuGetCredProvider; do the same
for the build, codeql and docs workflows.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 14, 2026
This was referenced Sep 28, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MultiplexingStreamPerfTeststests (net472 only) intermittently fail in CI — most recently in the merge queue run for #1120 (run 30223830842) — with:This is unrelated to the pnpm bump in #1120.
Assigning the isolated test host process to a job object is only a best-effort safety net to kill orphaned child processes if the test process dies unexpectedly. It can fail for environmental reasons outside our control (e.g. the process already belongs to a job hierarchy that our job isn't part of, which can happen under the CI agent), so its failure should not fail the test. It is now logged as a warning instead.
Additionally, the Win32 error code is now captured immediately after the failed P/Invoke. The old code called
Process.HasExitedfirst, which issues its own interop calls and clobbers the last error — so the reported error code ("The parameter is incorrect") was likely bogus, obscuring the real cause.