Repository navigation
Standing block for decisions/vocabulary-model (#762) - #800
Merged
Merged
Conversation
#762) From the design-docs review: mul.toml is named as the home of words shared on purpose; the phase-3 pack behavior, the modifier rule and the contested-head gate are stated as design rather than as shipped; the surname-list claim is scoped to the per-word vocabulary; decision 14 keeps its shape clause; lines added for edit kind 4, schema, the suffix kinds and native. A Not standing line records the carried-out und.toml plans and #747's no-longer-true reason for the und.toml exemption, and build.py's UNORDERED comment gives the README's reason instead. #326 joins Open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd.toml exemption entry (#762) The modifier line claimed a title in every position; it is read as any title is, in front only. mul.toml's list now names 2 and the full-word titles. The und.toml exemption's new ground gets a dated 2026-10-21 #762 entry rather than living in the Not standing line. #326 leaves Open: it sits under #754 and decisions/suffix-field-composition declined it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #800 +/- ##
=======================================
Coverage 99.05% 99.05%
=======================================
Files 47 47
Lines 4642 4642
=======================================
Hits 4598 4598
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #762, batch 2. It goes first because #752 (vocabulary phase 2) will add entries to this file.
What changed
docs/design/decisions/vocabulary-model.mdgains a## Standingblock, 24 present-tense lines, each pointing at its entry, followed by a## Logheading.2026-10-19 #750entries and the two2026-10-20 #751entries. Each pointer to one of them carries the words its entry's text opens with.e/y/ione-case fork, themodifierrule, the contested-head gate and the patronymic field.Not standing:line covers the plans the classifications carried out. One is phase 1's interim conversion intound.toml; the other is Classify the particles in und.toml by language and kind #749's "stay where they were until classified". It also covers Vocabulary model and language packs (tracking) #747's reason for exemptingund.tomlfrom the order check, which no longer holds.und.tomlstays exempt from check 10 because it holds no language's words, the reasonnameparser/vocab/README.mdalready gives. Approved by Derek in chat, 2026-10-21. It re-grounds an existing exemption rather than deciding anything new.tools/vocab/build.py: theUNORDEREDcomment now gives that reason. It used to cite vetting comments ("Same word as عبد below") that left with Classify the particles in und.toml by language and kind #749–Assign languages to the credentials and the remaining und.toml words #751.vocabulary-modelis offtests/v2/decisions_without_standing.json.suffixsplit intogenerationandcredentials? (Smith, Jr., PhD) #326 is left off: it is a sub-issue of Phase 4: order and shapes, the rules a pack can choose, and the output model #754, and decisions/suffix-field-composition already declined it for 2.x.Checked
docs/design/for every issue cited. No other file reverses part of an entry here, so no entry head needed a "superseded by" note.Dean Smith→ given DeanWm Smith→ title WmVice John Smith→ title Vice, whileJohn Smith Vice→ family Vicee,yandiare conjunctions;dean,justiceandmajorare not titles;und.tomlholds onlybonanddí; no credential is inmul.toml; the phase-2–4 key names andaddresses = "full"/"any"are refused by the build.uv run pytest -qpasses on 3.11 and on 3.15: 22464 passed, 125 skipped, 3 xfailed each time. That run was before the review fixes, which touch only docs and a comment; the doc and vocab tests pass on the final tree.Found stale, not fixed here
zh.toml, linked bysame_as, and the Standing line states only the general rule.🤖 Generated with Claude Code