Proposal: remove DEBUG_FD #386

Activity

1. thebigredgeek commented on Dec 21, 2016

   

   thebigredgeek

   on Dec 21, 2016

   Contributor

   More actions

   I think that's fine. Doesn't really seem like this many configuration opens should be provided anyway. The API should be simple while also extensible
2. TooTallNate commented on Dec 21, 2016

   

   TooTallNate

   on Dec 21, 2016

   ContributorAuthor

   More actions

   There is this part in the README:

   Note: Certain IDEs (such as WebStorm) don't support colors on stderr. In these cases you must set DEBUG_COLORS to 1 and additionally change DEBUG_FD to 1.

   But seems like more of a WebStorm issue IMO.
3. thebigredgeek commented on Dec 21, 2016

   

   thebigredgeek

   on Dec 21, 2016

   Contributor

   More actions

   Yeah agreed. And in this case I am not sure how many of our users actually use webstorm. Wish there were metrics haha
4. thebigredgeek commented on Dec 21, 2016

   

   thebigredgeek

   on Dec 21, 2016

   Contributor

   More actions

   We should probably move this here
5. TooTallNate commented on Dec 21, 2016

   

   TooTallNate

   on Dec 21, 2016

   ContributorAuthor

   More actions

   Removal should go into v3, and we should have a deprecation warning in a v2 release to let anyone potentially using the env var to stop or speak up.
6. thebigredgeek commented on Dec 21, 2016

   

   thebigredgeek

   on Dec 21, 2016

   Contributor

   More actions

   @TooTallNate you wanna add the warning? Creating a v3 branch now
7. TooTallNate

   added a commit that references this issue on Dec 27, 2016

   remove DEBUG_FD

   ...

   This issue will close once commit 6b5ae03 is merged into the 'master' branch.

   6b5ae03
8. thebigredgeek

   added a commit that references this issue on Dec 28, 2016

   Remove DEBUG_FD (#406)

   ...

   This issue will close once commit dade81d is merged into the 'master' branch.

   dade81d
9. thebigredgeek

   closed this as completedon Dec 28, 2016
10. thebigredgeek

    added a commit that references this issue on Apr 12, 2017

    Remove DEBUG_FD (#406)

    ...

    This issue will close once commit c9ff8e7 is merged into the 'master' branch.

    c9ff8e7
11. TooTallNate

    added 2 commits that reference this issue on Aug 8, 2017

    Remove DEBUG_FD (#406)

    ...

    This issue will close once commit 56ba594 is merged into the 'master' branch.

    56ba594

    Remove DEBUG_FD (#406)

    ...

    This issue will close once commit ff432e7 is merged into the 'master' branch.

    ff432e7