Repository navigation
Conversation
DiegoDAF
added a commit
to DiegoDAF/pgcli.daf
that referenced
this pull request
Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After
BEGIN; SELECT 1 / 0;, running\ef function_nameor\ev view_nameraisesInFailedSqlTransactionand exits pgcli. The interactive editor handler catchesRuntimeError, but these metadata queries can also raise a psycopgDatabaseError.Handle database errors at the existing editor error boundary, print the original message, and return to the prompt. The transaction remains aborted until the user chooses to roll it back. Both editor commands have regression tests using a real PostgreSQL connection, including recovery with
ROLLBACKand a subsequent query.Related to #1392. I reproduced the crash in an aborted transaction;
BEGINalone allowed function editing in my environment.Validation on Linux / Python 3.12 / PostgreSQL 18.6:
ROLLBACKand another query, and exits normally.The full upstream Python/PostgreSQL version matrix was not run locally. AI-assisted implementation and validation.
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).