Skip to content

[6.x] Open admin table rows on double-click - #19957

Merged
brandonkelly merged 8 commits into
6.xfrom
feature/6x-admin-table-row-double-click
Oct 15, 2026
Merged

brandonkelly merged 8 commits into
6.xfrom
feature/6x-admin-table-row-double-click

Conversation

@nfourtythree

@nfourtythree nfourtythree commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

Double-clicking an admin table row opens its first-column link. Ordinary links navigate normally, links with slideout: true reuse the existing slideout handling, including width and refresh options.

Double-clicks on interactive controls, modified double-clicks and canceled events leave the row alone.

Stacked on #19956, targeting feature/6x-admin-table-slideouts. Merge that PR first.

@nfourtythree nfourtythree self-assigned this Oct 13, 2026
@nfourtythree
nfourtythree added this pull request to stack #19958 October 13, 2026 10:54
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

📚 Storybook previews

@craftcms/ui — open Storybook

No changed components detected in this Storybook.

resources/js — open Storybook

No changed components detected in this Storybook.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Associated form labels can activate their controls while also triggering the row-opening action.

1 open finding
What changed in this PR

Adds double-click navigation to admin table rows while reusing existing link and slideout behavior.

Changes:

  • Emits row double-click events while ignoring controls, modifiers, canceled events, and busy tables.
  • Opens first-column links through Inertia or existing slideout handling.
  • Adds behavioral tests and documentation.
File Description
src/​Ui/​Nodes/​Table.php Documents row double-click behavior.
resources/​js/​modules/​ui/​AdminTableNode.vue Resolves and opens each row’s primary link.
resources/​js/​modules/​admin-table/​components/​AdminTableData.browser.test.ts Tests navigation, slideouts, cancellation, and controls.
resources/​js/​modules/​admin-table/​components/​AdminTable.vue Forwards row double-click events.
resources/​js/​common/​utils/​dom.ts Expands interactive-element detection.
resources/​js/​common/​components/​DataTable.vue Detects eligible row double-clicks.
resources/​js/​common/​components/​DataTable.test.ts Tests row event filtering.
CHANGELOG-WIP.md Records the new interaction.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread resources/js/common/utils/dom.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation preserves existing link and slideout behavior with strong coverage for interaction edge cases.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

Base automatically changed from feature/6x-admin-table-slideouts to 6.x October 15, 2026 01:54
…-row-double-click

# Conflicts:
#	CHANGELOG-WIP.md
@github-actions

Copy link
Copy Markdown

This PR had conflicts with 6.x. Claude attempted an automatic resolution and pushed a merge commit. Please review the merge commit carefully before approving/merging.

Claude's response

I resolved the one conflict, committed the merge as 5f0632c, and did not push.

The conflict was in CHANGELOG-WIP.md, in the "Control Panel" section. Each side had added different lines to the same spot:

  • This branch: one entry saying that double-clicking an admin table row opens its link's slideout.
  • 6.x: two entries for [6.x] Resizable slideouts #19978, saying slideouts can be resized horizontally and that folded-away details panes reopen once there's enough room.

The entries describe separate features, so I kept all three, with this branch's entry first and the 6.x entries after it. Nothing was ambiguous, so I didn't leave any CONFLICT-REVIEW comments. Every other file merged cleanly without needing changes.

brandonkelly and others added 3 commits October 14, 2026 19:01
…-row-double-click

# Conflicts:
#	CHANGELOG-WIP.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e-click' into feature/6x-admin-table-row-double-click

# Conflicts:
#	CHANGELOG-WIP.md
@brandonkelly
brandonkelly merged commit d0c3d14 into 6.x Oct 15, 2026
20 checks passed
@brandonkelly
brandonkelly deleted the feature/6x-admin-table-row-double-click branch October 15, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants