Skip to content

Keep leading spaces in paragraphs when there's a list #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AfzalivE wants to merge 1 commit into from
Closed

Keep leading spaces in paragraphs when there's a list #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion commonmark/src/main/java/org/commonmark/internal/DocumentParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ private void parseLine(CharSequence ln) {

BlockStartImpl blockStart = findBlockStart(blockParser);
if (blockStart == null) {
setNewIndex(nextNonSpace);
if (!blockParserFactories.isEmpty()) {
setNewIndex(nextNonSpace);
}
break;
}

Expand Down
29 changes: 29 additions & 0 deletions commonmark/src/test/java/org/commonmark/test/ParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,35 @@ public void indentation() {
assertEquals("tab + space", firstText(list.getFirstChild().getNext()));
}

@Test
public void indentationInParagraph() {
String given = " - 1 space\n - 3 spaces\n - 5 spaces\n\t - tab + space";
Parser parser = Parser.builder()
.enabledBlockTypes(new HashSet<Class<? extends Block>>())
.build();
Node document = parser.parse(given);

assertThat(document.getFirstChild(), instanceOf(Paragraph.class));

Node list = document.getFirstChild();
Node firstChild = list.getFirstChild(); // first item
assertEquals(" - 1 space", firstText(firstChild));

Node secondChild = firstChild.getNext(); // second item
assertThat(secondChild, instanceOf(SoftLineBreak.class));
assertEquals(" - 3 spaces", firstText(secondChild.getNext()));

Node fourthChild = secondChild.getNext().getNext();
assertThat(fourthChild, instanceOf(SoftLineBreak.class));

assertEquals(" - 5 spaces", firstText(fourthChild.getNext()));

Node sixthChild = fourthChild.getNext().getNext();
assertThat(sixthChild, instanceOf(SoftLineBreak.class));

assertEquals("\t - tab + space", firstText(sixthChild.getNext()));
}

@Test
public void inlineParser() {
final InlineParser fakeInlineParser = new InlineParser() {
Expand Down